Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest labels during check creation / editing #894

Open
ckbedwell opened this issue Aug 1, 2024 · 1 comment
Open

Suggest labels during check creation / editing #894

ckbedwell opened this issue Aug 1, 2024 · 1 comment
Assignees
Labels

Comments

@ckbedwell
Copy link
Contributor

ckbedwell commented Aug 1, 2024

Problem

Currently when adding labels to checks during check creation / editing you want to view and re-use existing labels. Typing them manually is very error prone or it is likely to result in labels that are very similar but ever-so-slightly different (e.g. team:fe vs team:frontend, etc.)

Completion criteria

The completion criteria is a little open-ended for this ticket. There is plenty of screen real estate for us to explore suitable solutions. Consider that we want to prompt users to add labels based on what is existing when they have no idea what to add but if a tenant has thousands of differing labels we don't want to show them all. On the other hand if a tenant only has a few labels we may want to show them all. Possibly show a top ten with the option to show more 20, 30, all, etc?

Please also consider a UI that adds:

  • Adding auto-suggestion for the name field with what is existing
  • Adding auto-suggestion for the value field based on the input in the name field

Please ensure the solution has the appropriate integration tests added.

Additional considerations

As we currently fetch all checks in our useChecks call (even if there are thousands and the response is tens of megabytes long...) we have all the data available to know what labels are available to re-use across all checks. However this may change at some point and there could be a separate labels api so please ensure your solution is flexible enough to support a change in how we would gather the labels information.

@ckbedwell ckbedwell added the enhancement New feature or request label Aug 1, 2024
@w1kman
Copy link
Contributor

w1kman commented Oct 28, 2024

Ran into some issues with being able to focus the react-select component (which doesn't play nice at all with react-hook-forms.

I will revisit this one after #892 is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants