Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should getFirst have an alias setLimit #2399

Open
hos opened this issue Mar 5, 2025 · 0 comments
Open

Should getFirst have an alias setLimit #2399

hos opened this issue Mar 5, 2025 · 0 comments

Comments

@hos
Copy link
Contributor

hos commented Mar 5, 2025

Summary

I'm not sure I get all the steps correctly, but if so:
As discussed in discord thread, setFirst is not very expected on pg class steps. In the channel Benjie proposed to "I should probably add a setLimit alias for setFirst", which, in my opinion may add a confusion. What I would rather expect, to only have setLimit, as we are in the context of PgClass step. setFirst makes more sense when we are in the context of connection step.

Additional context

@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🌳 Triage
Development

No branches or pull requests

1 participant