Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate resolvePresets in favour of resolvePreset #2253

Merged
merged 12 commits into from
Nov 27, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Nov 27, 2024

Description

Replaces resolvePresets([preset]) with resolvePreset(preset) - opens the door to future generics if need be.

ResolvedPreset can no longer be an empty object, you MUST process it via resolvePreset: resolvedPreset: {} would become resolvedPreset: resolvePreset({})

Performance impact

Unlikely to be significant, though fewer presets will be treated as resolved presets and thus slightly more time might be needed to process presets sometimes maybe.

Security impact

Unknown.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Nov 27, 2024

🦋 Changeset detected

Latest commit: 2c8cb5e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
graphile-config Patch
@localrepo/grafast-bench Patch
@dataplan/pg Patch
grafast Patch
@grafserv/persisted Patch
grafserv Patch
ruru Patch
graphile-build-pg Patch
graphile-build Patch
graphile-utils Patch
pgl Patch
postgraphile Patch
graphile Patch
@dataplan/json Patch
ruru-components Patch
@localrepo/grafast-website Patch
graphile-export Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit ae2bf43 into main Nov 27, 2024
42 checks passed
@benjie benjie deleted the rework-resolved-preset branch November 27, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant