fix: disable default required type for mongoose conditional required fields (#204)

antoniopresto · nodkz · commit dfa0e2182e69 · 2020-01-21T13:54:24.000+06:00
diff --git a/src/resolvers/createMany.js b/src/resolvers/createMany.js
@@ -41,7 +41,7 @@ export default function createMany<TSource: MongooseDocument, TContext>(
   for (const field in tree) {
     if (tree.hasOwnProperty(field)) {
       const fieldOptions = tree[field];
-      if (fieldOptions.required) {
+      if (fieldOptions.required && typeof fieldOptions.required !== 'function') {
         requiredFields.push(field);
       }
     }
diff --git a/src/resolvers/createOne.js b/src/resolvers/createOne.js
@@ -26,7 +26,7 @@ export default function createOne<TSource: MongooseDocument, TContext>(
   for (const field in tree) {
     if (tree.hasOwnProperty(field)) {
       const fieldOptions = tree[field];
-      if (fieldOptions.required) {
+      if (fieldOptions.required && typeof fieldOptions.required !== 'function') {
         requiredFields.push(field);
       }
     }

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ export default function createMany<TSource: MongooseDocument, TContext>(`
`41`	`41`	`for (const field in tree) {`
`42`	`42`	`if (tree.hasOwnProperty(field)) {`
`43`	`43`	`const fieldOptions = tree[field];`
`44`		`- if (fieldOptions.required) {`
	`44`	`+ if (fieldOptions.required && typeof fieldOptions.required !== 'function') {`
`45`	`45`	`requiredFields.push(field);`
`46`	`46`	`}`
`47`	`47`	`}`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ export default function createOne<TSource: MongooseDocument, TContext>(`
`26`	`26`	`for (const field in tree) {`
`27`	`27`	`if (tree.hasOwnProperty(field)) {`
`28`	`28`	`const fieldOptions = tree[field];`
`29`		`- if (fieldOptions.required) {`
	`29`	`+ if (fieldOptions.required && typeof fieldOptions.required !== 'function') {`
`30`	`30`	`requiredFields.push(field);`
`31`	`31`	`}`
`32`	`32`	`}`