Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There's some way to set the source field param for nested fields? #1439

Open
alexrintt opened this issue Jul 28, 2022 · 3 comments
Open

There's some way to set the source field param for nested fields? #1439

alexrintt opened this issue Jul 28, 2022 · 3 comments

Comments

@alexrintt
Copy link

Context

I'm currently trying to set my model user User subfield user.actor.id as field source of my DjangoObjectType.

This happens because there's other kind of users within the application like an Organization or even a Bot (all of them are actors).

Example

Lets define a custom Type:

class User(DjangoObjectType):
    class Meta:
        model = UserModel
        exclude = ['actor']
        filter_fields = ['actor__login']
        interfaces = [graphene.relay.Node]
        skip_registry = True

    # The login field is originated from `actor` relationship, not from the user model itself.
    # It doesn't work, actor__login is interpreted as user field [user.actor__login] not [user.actor.login].
    login = graphene.Field(graphene.String, source='actor__login')
    # ...

In the example above I define the login field source as source='actor__login' but I saw that here we're using getattr function to resolve the source so it's currently impossible to set the field without defining a custom resolver.

def source_resolver(source, root, info, **args):
resolved = default_resolver(source, None, root, info, **args)
if inspect.isfunction(resolved) or inspect.ismethod(resolved):
return resolved()
return resolved

I would like to know if there's an alternative solution to select a subfield like the example or we're forced to create a custom resolver by using the resolver=lambda _, __: ... arg or the class method declaration.

Thanks for the hard work and the library!

@erikwrede
Copy link
Member

I think you'll need to create a resolver returning root.actor.login/resolving the actor first depending on your setup.

@alexrintt
Copy link
Author

Yeah, but since it's only field configuration I created a function to generate the resolver itself:

def subfield(source, separator='.'):
    def resolver(self, info, *args, **kwargs):
        value = self
        for part in source.split(separator):
            value = getattr(value, part)
        return value

    return resolver


def source(source, separator='.'):
    return {'resolver': subfield(source, separator)}

Usage:

class User(DjangoObjectType):
    class Meta:
        model = UserModel
        exclude = ['actor']
        filter_fields = ['actor__login']
        interfaces = [Node]
        skip_registry = True

    login = graphene.Field(graphene.String, **source('actor.login'))
    # ...

@erikwrede
Copy link
Member

Sorry for the late reply, didn't get the notification. Looks interesting! Do you want to open a PR and integrate it into the main repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants