Parse extend schema correctly when root operations list is absent
#3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8647065 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
trevor-scheer
changed the title
extend schema parsing issue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3670 +/- ##
==========================================
+ Coverage 65.32% 65.35% +0.02%
==========================================
Files 122 122
Lines 7003 7003
Branches 2260 2265 +5
==========================================
+ Hits 4575 4577 +2
+ Misses 2411 2409 -2
Partials 17 17
|
trevor-scheer
changed the title
extend schema parsing issueextend schema correctly when root operations list is absent
|
Sorry @trevor-scheer — I am not familiar with the code base here. Just have contributed what I could to get incremental delivery moving… |
|
Hey @acao, is there anything I can do to help move this along? |
TallTed
reviewed
Nov 26, 2024
|
|
||
| Previously, the parser gave schema extensions the same treatment as schema definitions. The requirements are slightly different, however, since a schema extension does not require a list of root operations according to the spec: https://spec.graphql.org/draft/#sec-Schema-Extension. | ||
|
|
||
| The rule for parsing a schema extension is now distinct from schema definition, allowing the root operations list to be omitted. |
There was a problem hiding this comment.
Suggested change
| The rule for parsing a schema extension is now distinct from schema definition, allowing the root operations list to be omitted. | |
| The rule for parsing a schema extension is now distinct from that for a schema definition, allowing the root operations list to be omitted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The online parser currently expects to parse a schema extension the same way it parses a schema definition, however the rules vary slightly in that the list of root operations can be omitted.
This change treats them as two distinct rules, allowing the list to be optional in
extendcase.