Change: Use new report generation for delta report #2095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report
🚀 Conventional commits found. |
|
Hi, could you describe how the new diff report behaves in contrast to the old one? |
- The new report generation is enabled by changing the setting of "Delta Reports Version" to 2.
a-h-abdelsalam
force-pushed
the
delta-reports-v2
branch
from
a64c32f to
5f64b31
Compare
…tion - Treat "package" and "general/tcp" the same for delta comparison - Ensure results are included in delta reports if nvts are missing
jhelmold
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add new report generation for delta reports. The new report generation is enabled by changing the setting of "Delta Reports Version" to 2.
The new delta report generation gets the results for both reports in a single iterator instead of using two iterators.
It also changes how the "new" and "gone" status are determined by considering the first report the recent one and the delta report the older one and considering results with only changed severity, QoD or hostname as "changed" instead of "new" and "gone".
The result port "package" is handled the same as "general/tcp" for the delta comparison.
Why
The old version of delta report generation was based on the sort order which was not reliable.
The change in "new" and "gone" status was done to make it more consistent with how Alerts handle delta reports.
The port handling was adjusted so Notus results are not shown as "new"/"gone" when compared to a report without Notus.
References
General improvements:
Comparison handling: