Fix start gvmd script #2140
Merged
Fix start gvmd script #2140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conventional Commits Report😢 No conventional commits found. 👉 Learn more about the conventional commits usage at Greenbone. |
The line got duplicated likely when the license header was added.
Always use spaces instead of tabs.
…cript Testing if the PGRES_DATA env variable is already set missed a space before the closing bracket. Therefore it wasn't possible to override the to be used postgres data directory. When shellcheck warns you, you should give it attention.
There could be more then one user starting with admin in their names like foo_admin or admin_foo. Therefore fix the grep command to only show the user admin.
bjoernricks
force-pushed
the
fix-start-gvmd-script
branch
from
c373755 to
1f8d14e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Update and fix the container startup script
Why
It wasn't possible to override the postgres data dir and contained an issue when users similar to the initial user exist (like if the user is
adminand the usersfoo_adminandadmin_barexist).