Let Gtk handle tooltips

Add a TOOLTIP_COLUMN to the model,
store the text there (when appropriate),
and let the tree display tooltips automatically.

Author: ferdnyc

interface.c

@@ -24,42 +24,6 @@ static GtkTreeViewColumn *treeColumn;
 
 int timer;
 
-static gboolean
-query_tooltip_cb(GtkWidget *widget, gint x, gint y,
-			gboolean keyboard_tip, GtkTooltip *tooltip, void *unused)
-{
-	GtkTreeModel *model = gtk_tree_view_get_model(GTK_TREE_VIEW(treeUSB));
-	GtkTreePath *path = NULL;
-	GtkTreeIter iter;
-	gint cellx = 0, celly = 0;
-	gchar *color;
-	gboolean return_val = FALSE;
-
-	if (!model)
-		return FALSE;
-
-	/* This -30 is a kludge. It seems that if you don't do this, gtk_tree_view_get_path_at_pos()
-	 * gives you the wrong path, the path for the cell that is 30 or so pixels down below the
-	 * mouse. I don't know why it does that. Either we're doing something wrong, or it's a gtk-3
-	 * bug.
-	 */
-	y = y - 30;
-
-	if (!gtk_tree_view_get_path_at_pos(GTK_TREE_VIEW(widget), x, y, &path, &treeColumn, &cellx, &celly))
-		return FALSE;
-	if (!path)
-		return FALSE;
-	/* Get the color, if it's red, set tooltip to indicate device has no driver. */
-	gtk_tree_model_get_iter(model, &iter, path);
-	gtk_tree_model_get(model, &iter, COLOR_COLUMN, &color, -1);
-	if (color != NULL && strncmp(color, "red", 4) == 0) {
-		gtk_tooltip_set_text(tooltip, "This device has no attached driver");
-		return_val = TRUE;
-	}
-	gtk_tree_path_free(path);
-	return return_val;
-}
-
 GtkWidget*
 create_windowMain ()
 {
@@ -94,7 +58,8 @@ create_windowMain ()
 	treeStore = gtk_tree_store_new (N_COLUMNS,
 				G_TYPE_STRING,	/* NAME_COLUMN */
 				G_TYPE_INT,	/* DEVICE_ADDR_COLUMN */
-				G_TYPE_STRING	/* COLOR_COLUMN */);
+				G_TYPE_STRING,	/* COLOR_COLUMN */
+				G_TYPE_STRING	/* TOOLTIP_COLUMN */);
 	treeUSB = gtk_tree_view_new_with_model (GTK_TREE_MODEL (treeStore));
 	treeRenderer = gtk_cell_renderer_text_new ();
 	treeColumn = gtk_tree_view_column_new_with_attributes (
@@ -104,6 +69,10 @@ create_windowMain ()
 					"foreground", COLOR_COLUMN,
 					NULL);
 	gtk_tree_view_append_column (GTK_TREE_VIEW (treeUSB), treeColumn);
+	gtk_tree_view_set_tooltip_column(
+		GTK_TREE_VIEW (treeUSB), TOOLTIP_COLUMN
+	);
+
 	gtk_widget_set_name (treeUSB, "treeUSB");
 	gtk_widget_show (treeUSB);
 	gtk_paned_pack1 (GTK_PANED (hpaned1), treeUSB, FALSE, FALSE);
@@ -164,12 +133,9 @@ create_windowMain ()
 	g_signal_connect (G_OBJECT (buttonClose), "clicked",
 			    G_CALLBACK (on_buttonClose_clicked),
 			    NULL);
-	g_object_set(G_OBJECT (treeUSB), "has-tooltip", TRUE, NULL);
-	g_signal_connect(G_OBJECT (treeUSB), "query-tooltip", G_CALLBACK (query_tooltip_cb), NULL);
 
 	/* create our timer */
 	//timer = gtk_timeout_add (2000, on_timer_timeout, 0);
-	
+
 	return windowMain;
 }
-

usbtree.c

@@ -150,7 +150,7 @@ static void PopulateListBox (int deviceId)
 			/* show this config */
 			sprintf (string, "\n\nConfig Number: %i\n\tNumber of Interfaces: %i\n\t"
 				 "Attributes: %.2x\n\tMaxPower Needed: %s",
-				 config->configNumber, config->numInterfaces, 
+				 config->configNumber, config->numInterfaces,
 				 config->attributes, config->maxPower);
 			gtk_text_buffer_insert_at_cursor(textDescriptionBuffer, string,strlen(string));
 
@@ -169,7 +169,7 @@ static void PopulateListBox (int deviceId)
 
 					sprintf (string, "\n\t\tAlternate Number: %i\n\t\tClass: %s\n\t\t"
 						 "Sub Class: %.2x\n\t\tProtocol: %.2x\n\t\tNumber of Endpoints: %i",
-						 interface->alternateNumber, interface->class, 
+						 interface->alternateNumber, interface->class,
 						 interface->subClass, interface->protocol, interface->numEndpoints);
 					gtk_text_buffer_insert_at_cursor(textDescriptionBuffer, string, strlen(string));
 
@@ -181,7 +181,7 @@ static void PopulateListBox (int deviceId)
 							sprintf (string, "\n\n\t\t\tEndpoint Address: %.2x\n\t\t\t"
 								 "Direction: %s\n\t\t\tAttribute: %i\n\t\t\t"
 								 "Type: %s\n\t\t\tMax Packet Size: %i\n\t\t\tInterval: %s",
-								 endpoint->address, 
+								 endpoint->address,
 								 endpoint->in ? "in" : "out", endpoint->attribute,
 								 endpoint->type, endpoint->maxPacketSize, endpoint->interval);
 							gtk_text_buffer_insert_at_cursor(textDescriptionBuffer, string,strlen(string));
@@ -224,6 +224,7 @@ static void DisplayDevice (struct Device *parent, struct Device *device)
 	int		interfaceNum;
 	gboolean	driverAttached = TRUE;
 	gint		deviceAddr;
+	const gchar	*tooltip = NULL;
 	const gchar	*color = NULL;
 
 	if (device == NULL)
@@ -251,13 +252,16 @@ static void DisplayDevice (struct Device *parent, struct Device *device)
 	}
 
 	/* change the color of this leaf if there are no drivers attached to it */
-	if (driverAttached == FALSE)
+	if (driverAttached == FALSE) {
 		color = "red";
+		tooltip = "This device has no attached driver";
+	}
 
 	gtk_tree_store_set (treeStore, &device->leaf,
 			    NAME_COLUMN, device->name,
 			    DEVICE_ADDR_COLUMN, deviceAddr,
 			    COLOR_COLUMN, color,
+			    TOOLTIP_COLUMN, tooltip,
 			    -1);
 
 	/* create all of the children's leafs */
@@ -306,4 +310,3 @@ void initialize_stuff(void)
 {
 	return;
 }
-

usbtree.h

@@ -10,6 +10,7 @@ enum {
 	NAME_COLUMN,
 	DEVICE_ADDR_COLUMN,
 	COLOR_COLUMN,
+	TOOLTIP_COLUMN,
 	N_COLUMNS
 };