Skip to content

Commit 6d7ad34

Browse files
committed
Addressing comments about getAnchor
1 parent 913c7ca commit 6d7ad34

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

test/nbrowser/DocTutorial.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ describe('DocTutorial', function () {
382382

383383
it('does not play an easter egg when opening an anchor link encoded with rr', async function() {
384384
await gu.getCell({rowNum: 1, col: 0}).click();
385-
const link = await gu.getAnchor({wait: true});
385+
const link = await gu.getAnchor();
386386
const easterEggLink = link.replace('.r1', '.rr1');
387387
await driver.get(easterEggLink);
388388
await gu.waitForAnchor();

test/nbrowser/gristUtils.ts

+10-2
Original file line numberDiff line numberDiff line change
@@ -1753,6 +1753,7 @@ export async function isRawTableOpened() {
17531753

17541754
export async function closeRawTable() {
17551755
await driver.find('.test-raw-data-close-button').click();
1756+
await waitToPass(async () => assert.isFalse(await driver.find('.test-raw-data-close-button').isPresent()));
17561757
}
17571758

17581759
/**
@@ -3392,8 +3393,11 @@ export async function waitForAnchor() {
33923393
export async function copyAnchor() {
33933394
await driver.find('body').sendKeys(Key.chord(Key.SHIFT, await modKey(), 'a'));
33943395

3395-
await waitToPass(async () => assert.match(
3396-
await driver.find('.test-tooltip').getText(), /Link copied to clipboard/), 1000);
3396+
await waitToPass(async () => {
3397+
assert.isTrue(
3398+
await driver.findContentWait('.test-notifier-toast-message', /Link copied to clipboard/, 100).isDisplayed()
3399+
)
3400+
});
33973401
}
33983402

33993403
export async function getAnchor() {
@@ -3416,6 +3420,7 @@ export async function getSectionTitles() {
34163420
export async function renameSection(sectionTitle: string, name: string) {
34173421
const renameWidget = driver.findContent(`.test-viewsection-title`, sectionTitle);
34183422
await renameWidget.find(".test-widget-title-text").click();
3423+
await driver.findWait('.test-widget-title-popup', 100);
34193424
await driver.find(".test-widget-title-section-name-input").click();
34203425
await selectAll();
34213426
await driver.sendKeys(name || Key.DELETE, Key.ENTER);
@@ -3424,6 +3429,7 @@ export async function renameSection(sectionTitle: string, name: string) {
34243429

34253430
export async function renameActiveSection(name: string) {
34263431
await driver.find(".active_section .test-viewsection-title .test-widget-title-text").click();
3432+
await driver.findWait('.test-widget-title-popup', 100);
34273433
await driver.find(".test-widget-title-section-name-input").click();
34283434
await selectAll();
34293435
await driver.sendKeys(name || Key.DELETE, Key.ENTER);
@@ -3435,6 +3441,7 @@ export async function renameActiveSection(name: string) {
34353441
*/
34363442
export async function renameActiveTable(name: string) {
34373443
await driver.find(".active_section .test-viewsection-title .test-widget-title-text").click();
3444+
await driver.findWait('.test-widget-title-popup', 100);
34383445
await driver.find(".test-widget-title-table-name-input").click();
34393446
await selectAll();
34403447
await driver.sendKeys(name, Key.ENTER);
@@ -3515,6 +3522,7 @@ export async function columnBehavior() {
35153522
*/
35163523
export async function availableBehaviorOptions() {
35173524
await driver.find('.test-field-behaviour').click();
3525+
await findOpenMenu();
35183526
const list = await driver.findAll('.grist-floating-menu li', el => el.getText());
35193527
await driver.sendKeys(Key.ESCAPE);
35203528
return list;

0 commit comments

Comments
 (0)