Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chokidar is only available when dev dependencies are installed #1399

Closed
2 tasks
Scandiravian opened this issue Jan 23, 2025 · 2 comments · Fixed by #1402
Closed
2 tasks

Chokidar is only available when dev dependencies are installed #1399

Scandiravian opened this issue Jan 23, 2025 · 2 comments · Fixed by #1402

Comments

@Scandiravian
Copy link
Contributor

Scandiravian commented Jan 23, 2025 •
edited
Loading

Describe the current behavior

When building chokidar is currently provided by chokidar-cli, which is listed as a dev dependency. If only the regular dependencies are provided, then grist fails due to the missing module.

Steps to reproduce

  1. Build grist with yarn build:prod
  2. Run yarn --prod install
  3. Start grist-core

Describe the expected behavior

It should be possible to run grist without having to install the dev dependencies, since they add approximately 400MiB to the install size.

Where have you encountered this bug?

Instance information (when self-hosting only)

  • Grist instance:

    • Version:
    • URL (if it's OK for you to share it):
    • Installation mode: docker/kubernetes/...
    • Architecture: single-worker/multi-workers

  • Browser name, version and platforms on which you could reproduce the bug:

  • Link to browser console log if relevant:

  • Link to server log if relevant:
@paulfitz
Copy link
Member

I see app/server/lib/DocStorageManager.ts using chokidar in a way that was relevant to an ancient version of Grist Desktop, but which could now be simply removed. I don't think it plays any role in regular Grist installs today.

@Scandiravian
Copy link
Contributor Author

I see app/server/lib/DocStorageManager.ts using chokidar in a way that was relevant to an ancient version of Grist Desktop, but which could now be simply removed. I don't think it plays any role in regular Grist installs today.

That sounds great - thanks for the quick reply! 😄

Scandiravian pushed a commit to Scandiravian/grist-core that referenced this issue Jan 27, 2025
chokidar is no longer used
5c08a08 
closes gristlabs#1399
@Scandiravian Scandiravian mentioned this issue Jan 27, 2025
Merged
4 tasks
Scandiravian pushed a commit to Scandiravian/grist-core that referenced this issue Jan 27, 2025
chokidar is no longer used
c31fc95 
closes gristlabs#1399
paulfitz pushed a commit that referenced this issue Jan 27, 2025
@Scandiravian
chokidar is no longer used (#1402)
2879b24 
## Context

I'm trying to add `grist-core` to nixpkgs and during testing it became
clear that `chokidar` is only available as a dev dependency.

## Proposed solution

Remove the import and use of `chokidar` as it's no longer used as per
#1399 (comment)

## Related issues

closes #1399

<!-- If suggesting a new feature or change, please discuss it in an
issue first -->
<!-- If fixing a bug, there should be an issue describing it with steps
to reproduce -->
<!-- If this does not solve entirely the issue, make also a checklist of
what is done or not: -->

## Has this been tested?

<!-- Put an `x` in the box that applies: -->

- [ ] 👍 yes, I added tests to the test suite
- [ ] 💭 no, because this PR is a draft and still needs work
- [x] 🙅 no, because this is not relevant here
- [ ] 🙋 no, because I need help <!-- Detail how we can help you -->

## Screenshots / Screencasts

<!-- delete if not relevant -->

Co-authored-by: Christian Ravn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chokidar is no longer used Scandiravian/grist-core
2 participants
@paulfitz @Scandiravian