-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an helper to display Icons in Icons.css #1426
Comments
That would be very useful! |
@georgegevoian @berhalak do you have any point of view on this? |
Yes, we already have something like that, but it is in the part of the test suite the wasn't moved yet, I will try to move it to grist-core. |
@berhalak Do you have any news on this? We would be very interested in what you have, if you are OK with open-sourcing it. |
Something appeared in c9c2ac9 that looks relevant |
I think @berhalak may be referring to something else? But this will certainly help with adding new icons - you can now just drop them somewhere in the static directory and run the script to update the client code and CSS. |
I'm referring to our project tests, one of them is used to show icons page. |
I started moving those tests, (here is a draft PR), but it will take some time. But you should already be able to use this branch to display list of icons:
Then navigate to http://localhost:8900/Icons |
Thanks a lot @berhalak |
Describe the problem to be solved
Context
While fixing #1412 I faced the difficulty of not being fluent in base64 😅 .
Icons in icons.css are not really readable, and I didn't found a doc displaying them all in a more human friendly format
Evolution proposal
If such a thing yet exists, tell me and I'll add a paragraph about it into dev documentation.
If not, I coded a little helper that I can may be add somewhere in the repo (cli, dev documentation or elsewhere)
Describe the solution you would like
No response
The text was updated successfully, but these errors were encountered: