Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an helper to display Icons in Icons.css #1426

Open
hexaltation opened this issue Feb 5, 2025 · 9 comments
Open

Add an helper to display Icons in Icons.css #1426

hexaltation opened this issue Feb 5, 2025 · 9 comments
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@hexaltation
Copy link
Collaborator

hexaltation commented Feb 5, 2025

Describe the problem to be solved

Context

While fixing #1412 I faced the difficulty of not being fluent in base64 😅 .

Icons in icons.css are not really readable, and I didn't found a doc displaying them all in a more human friendly format

Evolution proposal

If such a thing yet exists, tell me and I'll add a paragraph about it into dev documentation.

If not, I coded a little helper that I can may be add somewhere in the repo (cli, dev documentation or elsewhere)

Image

Describe the solution you would like

No response

@hexaltation hexaltation added enhancement New feature or request question Further information is requested labels Feb 5, 2025
@hexaltation hexaltation moved this to Needs feedback in French administration Board Feb 5, 2025
@manuhabitela
Copy link
Collaborator

That would be very useful!

@hexaltation
Copy link
Collaborator Author

@georgegevoian @berhalak do you have any point of view on this?

@berhalak
Copy link
Contributor

Yes, we already have something like that, but it is in the part of the test suite the wasn't moved yet, I will try to move it to grist-core.

@berhalak berhalak self-assigned this Feb 20, 2025
@fflorent
Copy link
Collaborator

@berhalak Do you have any news on this? We would be very interested in what you have, if you are OK with open-sourcing it.

@paulfitz
Copy link
Member

Something appeared in c9c2ac9 that looks relevant
cc also @georgegevoian

@georgegevoian
Copy link
Contributor

Something appeared in c9c2ac9 that looks relevant cc also @georgegevoian

I think @berhalak may be referring to something else? But this will certainly help with adding new icons - you can now just drop them somewhere in the static directory and run the script to update the client code and CSS.

@berhalak
Copy link
Contributor

I'm referring to our project tests, one of them is used to show icons page.

@berhalak
Copy link
Contributor

berhalak commented Feb 27, 2025

I started moving those tests, (here is a draft PR), but it will take some time. But you should already be able to use this branch to display list of icons:

npm run serve-projects

Then navigate to http://localhost:8900/Icons

@hexaltation
Copy link
Collaborator Author

Thanks a lot @berhalak

@hexaltation hexaltation moved this from Needs feedback to In Progress in French administration Board Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
Status: In Progress
Development

No branches or pull requests

6 participants