Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Attachment Storage" dropdown labels translations #1464

Closed
1 of 2 tasks
audez opened this issue Feb 19, 2025 · 0 comments · Fixed by #1465
Closed
1 of 2 tasks

Fix "Attachment Storage" dropdown labels translations #1464

audez opened this issue Feb 19, 2025 · 0 comments · Fixed by #1465
Assignees
@fflorent
Labels
gouv.fr translation

Comments

@audez
Copy link
Contributor

audez commented Feb 19, 2025

Describe the current behavior

In Settings > Attachment Storage, the dropdown labels "External" and "Internal" are not translated.

Steps to reproduce

  1. Set your browser in a language for which the 1.4.2 new strings are translated in Weblate
  2. In a Document, open "Settings"
  3. In "Attachment Storage" section, see that the dropdown labels "External" and "Internal" are not translated

Describe the expected behavior

All strings should be translated.

Where have you encountered this bug?

Instance information (when self-hosting only)

  • Grist instance:

  • Browser name, version and platforms on which you could reproduce the bug:

  • Link to browser console log if relevant:

  • Link to server log if relevant:
@fflorent fflorent assigned Spoffy and fflorent and unassigned Spoffy Feb 19, 2025
fflorent added a commit to betagouv/grist-core that referenced this issue Feb 19, 2025
@fflorent
l10n: fix missing translations for external storage options gristlabs…
76843b0 
…#1464

In document Settings > Attachment Storage, the dropdown labels "External" and "Internal" were not translated.
@fflorent fflorent mentioned this issue Feb 19, 2025
Merged
4 tasks
@fflorent fflorent moved this to Needs feedback in French administration Board Feb 19, 2025
fflorent added a commit to betagouv/grist-core that referenced this issue Feb 19, 2025
@fflorent
l10n: fix missing translations for attachments storage options gristl…
2135a78 
…abs#1464

In document Settings > Attachment Storage, the dropdown labels "External" and "Internal" were not translated.
paulfitz pushed a commit that referenced this issue Feb 19, 2025
@fflorent
l10n: fix missing translations for attachments storage options #1464 (#…
78d6552 
…1465)

## Context

In document Settings > Attachment Storage, the dropdown labels
"External" and "Internal" were not translated.

## Proposed solution

Call the `t()` function for the labels.

## Related issues

Fixes #1464 

## Has this been tested?

<!-- Put an `x` in the box that applies: -->

- [ ] 👍 yes, I added tests to the test suite
- [ ] 💭 no, because this PR is a draft and still needs work
- [x] 🙅 no, because this is not relevant here
- [ ] 🙋 no, because I need help <!-- Detail how we can help you -->
@github-project-automation github-project-automation bot moved this from Needs feedback to Done in French administration Board Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fflorent fflorent

Labels
gouv.fr translation
Projects
French administration Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

l10n: fix missing translations for attachments storage options #1464 betagouv/grist-core
3 participants
@fflorent @Spoffy @audez