Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar widget not useable when external CDNs are down #1514

Open
2 tasks done
apollo13 opened this issue Mar 14, 2025 · 5 comments
Open
2 tasks done

Calendar widget not useable when external CDNs are down #1514

apollo13 opened this issue Mar 14, 2025 · 5 comments

Comments

@apollo13
Copy link

Describe the current behavior

I just started a docker container to try out grist. After adding a calendar widget I got a blank page for the widget; this is currently happening because unpkg seems to be (partially?) down:

Image

Image

It would be really great if the widgets that are shipped inside grist directly did not rely on external CDNs

Steps to reproduce

Create a calendar widget and observe requests to unpkg failing (at least as off now)

Describe the expected behavior

Calendar widget should load.

Where have you encountered this bug?

Instance information (when self-hosting only)

No response

@paulfitz
Copy link
Member

Thanks for reporting. In principle this should have been done for grist-core, I guess the behavior has rusted?
#745

@apollo13
Copy link
Author

No idea? I mean is templates.getgrist.com using grist-core? Because it occurs there as well: https://templates.getgrist.com/uqUVorrMc23r/Field-Trip-Planner/p/9

@apollo13
Copy link
Author

apollo13 commented Mar 14, 2025

Oh @paulfitz the calendar is avalaible in the sense that it is visible in the UI, but it doesn't load because it's index.html uses external resources: https://github.com/gristlabs/grist-widget/blob/685aaa326c57f239a65f1b998355d1ae3df9b15a/calendar/index.html#L70-L73 (among others). I am not sure how the bundling would help there unless the npm packaging of grist-widgets gets rid of those.

EDIT:// Also Toast UI seems to be kinda unmaintained?

@paulfitz
Copy link
Member

I am not sure how the bundling would help there unless the npm packaging of grist-widgets gets rid of those.

Yes, that's exactly what it does - crawls them, rewrites links, bundles everything up. If you build Grist you can see the material living in node_modules/@gristlabs/grist-widget/. We're looking into it. Was working in the past, is not working today.

@apollo13
Copy link
Author

Ah that makes sense. I have looked into the container and it looks like it is shipping the bundled data:

Image

So the problem is not the grist-widget module but grist-core itself because it still loads the index.html for github directly:

https://gristlabs.github.io/grist-widget/calendar/index.html?access=full&readonly=false&culture=en-US&language=en-US&timeZone=Europe/Vienna&currency=USD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants