Fix: [DS-394] Badges are not static inside ListBoxItem & Tag (#491)

gsoft-inc · Oct 11, 2024 · cc983eb · cc983eb
2 parents ccdffd9 + c603aff
commit cc983eb
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/.changeset/gold-otters-suffer.md b/.changeset/gold-otters-suffer.md
@@ -0,0 +1,5 @@
+---
+"@hopper-ui/components": patch
+---
+
+Badge used to change appearance based on the states of its parent, but now Badge will remain the same when its parent's state changes.
diff --git a/packages/components/src/ListBox/src/ListBoxItem.tsx b/packages/components/src/ListBox/src/ListBoxItem.tsx
@@ -214,10 +214,7 @@ function ListBoxItemInner(props: ListBoxItemInnerProps) {
                     }],
                     [BadgeContext, {
                         className: styles["hop-ListBoxItem__badge"],
-                        isDisabled: isDisabled,
-                        isHovered: isHovered,
-                        isPressed: isPressed,
-                        isSelected: isSelected
+                        isDisabled: isDisabled
                     }],
                     [AvatarContext, {
                         className: styles["hop-ListBoxItem__avatar"],

diff --git a/packages/components/src/tag/src/Tag.tsx b/packages/components/src/tag/src/Tag.tsx
@@ -144,7 +144,7 @@ function Tag(props: TagProps, ref: ForwardedRef<HTMLDivElement>) {
             data-loading={isLoading || undefined}
         >
             {tagProps => {
-                const { allowsRemoving, isDisabled, isSelected, isPressed, isHovered } = tagProps;
+                const { allowsRemoving, isDisabled, isSelected } = tagProps;
 
                 return (
                     <>
@@ -171,10 +171,7 @@ function Tag(props: TagProps, ref: ForwardedRef<HTMLDivElement>) {
                                                 badgeVariant
                                             );
                                         },
-                                        isDisabled: isDisabled,
-                                        isHovered: isHovered,
-                                        isPressed: isPressed,
-                                        isSelected: isSelected
+                                        isDisabled: isDisabled
                                     }],
                                     [AvatarContext, {
                                         className: styles["hop-Tag__avatar"],