-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Modify the icon optimization + component generation in a pipeline, instead of doing it every build #105
Conversation
|
✅ Deploy Preview for wl-hopper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
… into feat/icon_flow
At the moment, everytime we build, we do the following:
This results in longer average build steps for all PRs, even when unrelated to icon changes. And it will be increasingly longer the more icons we add to the package.
Following this PR, building the packages will only results:
The process of adding / updating / removing an icon is detailed here:
Adding a new icon
packages/svg-icons/src/icons/16px
packages/svg-icons/src/icons/24px
packages/svg-icons/src/icons/32px
Updating or removing an icon
Updating or removing an icon is similar to adding a new icon. The only difference is that you will need to delete the SVGs from the following folders:
packages/svg-icons/src/icons/16px
packages/svg-icons/src/icons/24px
packages/svg-icons/src/icons/32px
Steps 2-4 are the same as adding a new icon.