Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve README #28

Open
5 tasks
gsuuon opened this issue Oct 17, 2023 · 4 comments
Open
5 tasks

Improve README #28

gsuuon opened this issue Oct 17, 2023 · 4 comments
Labels
documentation Improvements or additions to documentation

Comments

@gsuuon
Copy link
Owner

gsuuon commented Oct 17, 2023

  • give a full setup example with options using lazy.nvim
  • better document how to author prompts (input, context)
  • guide to adding providers (sse utils, calling handlers)
  • better distinguish chat prompts vs completion prompts
  • openai compat example
@gsuuon gsuuon added the documentation Improvements or additions to documentation label Oct 17, 2023
@FlippingBinary
Copy link

An example of how to use this plugin with an Ollama server would be great. It looks like this plugin could work with it pretty easily, so I'm going to star this repository and come back to it when I've got some time to fiddle with it.

@codetalker7
Copy link
Contributor

codetalker7 commented Sep 7, 2024

Some minor points which could help someone like me reading through the README:

  1. For models which require API access, it'll be great to have more examples of chats/templates for non-OpenAI providers (eg. HuggingFace or Groq Cloud; by the way, I think Groq would be a really nice addition to the list of available providers). Maybe it's just a personal taste, but I prefer to "test" out the plugin first with APIs for which I don't have to pay :) And perhaps one of the reasons I love this plugin is because it supports everything: local models, or practically any provider.
  2. Many thanks for the notes on the types/classes that are being used in calling the models! However, while going through the implementation of some providers like OpenAI or HuggingFace, I found some things which were a bit hard to understand on the first attempt. For instance, I had no idea about what the on_message handler does (eg:
    on_message = function(message, pending)
    ) and there wasn't any information about it in the README!
  3. I think the "Examples" section of the README is really good; however, in that section (and in other parts of the README) some videos are used to showcase the power of the plugin. While videos are great (and I really appreciate it), I think they should be accompanied with more docs explaining the stuff as well (because I'll probably look at the docs first, and then an example via any video or image!)

Overall the plugin is really amazing, and I'd love to see (or maybe even contribute) to various other usecases it may provide!

@gsuuon
Copy link
Owner Author

gsuuon commented Sep 8, 2024

Thanks for the detailed feedback! I'll reference this when I take another pass at the readme. I've also been thinking of adding a tutorial style section that walks through building your own prompts, which would address one of your points.
Also, contributions are definitely welcome (maybe a Groq provider?)

@codetalker7
Copy link
Contributor

Thanks for the detailed feedback! I'll reference this when I take another pass at the readme. I've also been thinking of adding a tutorial style section that walks through building your own prompts, which would address one of your points. Also, contributions are definitely welcome (maybe a Groq provider?)

Yes! I'll try to make a PR for a simple Groq chat template as well; will try to make it simple to understand and possibly will include some info in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants