Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency with gems that are not required #553

Open
tamiradari opened this issue Apr 5, 2022 · 3 comments
Open

dependency with gems that are not required #553

tamiradari opened this issue Apr 5, 2022 · 3 comments

Comments

@tamiradari
Copy link

Both rb-fsevent and rb-inotify are in the dependency in listen-3.7.1.gemspec.
But:

  • For Linux only rb-inotify is required.
  • For Darwin (OSX) only rb-fsevent is required.
  • For Windows, none of them is required (WDM can be added).
@tamiradari tamiradari changed the title dependency for gems that are not required dependency with gems that are not required Apr 5, 2022
@ColinDKelley
Copy link
Collaborator

@tamiradari These are good points.

Could you possibly submit a PR that makes these dependencies conditional?

@uvlad7
Copy link

uvlad7 commented Oct 27, 2024

It's easy to make them conditional, but you'll need to publish separate OS-specific versions of the gem

@ColinDKelley
Copy link
Collaborator

If anyone is inspired to make a PR that breaks out to OS-specific versions, please do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants