Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2 Nuget package numbering has reset somehow #3779

Closed
tznind opened this issue Oct 8, 2024 · 14 comments
Closed

v2 Nuget package numbering has reset somehow #3779

tznind opened this issue Oct 8, 2024 · 14 comments
Labels
bug build-and-deploy Issues regarding to building and deploying Terminal.Gui v2 For discussions, issues, etc... relavant for v2
Milestone

Comments

@tznind
Copy link
Collaborator

tznind commented Oct 8, 2024

Describe the bug
Nuget shows latest v2 package as 2329 1 month ago but also 12 days ago we have 526

Surely the latest should be the highest number?

image

@tznind tznind added bug build-and-deploy Issues regarding to building and deploying Terminal.Gui v2 For discussions, issues, etc... relavant for v2 labels Oct 8, 2024
@tig
Copy link
Collaborator

tig commented Oct 8, 2024

Arrrg.

I'll try to figure this out.

Sorry about that.

@tig
Copy link
Collaborator

tig commented Oct 8, 2024

To be clear, this is for v2_develop.

IMO if folks are referencing v2 via Nuget they should be using v2_release builds. And I need to merge to v2_release more often.

@tig tig added this to the V2 Beta milestone Nov 18, 2024
@sburbano
Copy link

sburbano commented Dec 3, 2024

@tig Just to clarify

IMO if folks are referencing v2 via Nuget they should be using v2_release builds. And I need to merge to v2_release more often.

image

image

By v2_release builds you mean prealpha?

@pebezo
Copy link

pebezo commented Feb 2, 2025

Please consider unlisting the old package versions

@tznind
Copy link
Collaborator Author

tznind commented Feb 3, 2025

Please consider unlisting the old package versions

The most recent designer compatible v2 release is still 2203

A better approach would just be bumping, build version number, and release.

I will start the work of bringing TGD up to date with latest v2 breaking changes.

@pebezo
Copy link

pebezo commented Feb 3, 2025

It took me longer than I care to admit to notice that I was working with an old version. Bumping the version to 2.0.0-v2-develop.3xxx should fix NuGet and IDEs.

@tznind
Copy link
Collaborator Author

tznind commented Feb 3, 2025

@tig can we just push a tag to bump the version e.g.

git tag v2.0.0-v2-develop.3000
git push --tags

@tznind
Copy link
Collaborator Author

tznind commented Feb 18, 2025

@tig appreciate that you are busy but when you have some capacity can we please prioritize solving this issue.

It is causing ongoing problems for users e.g. #3908

I have started updating TGD to the latest v2 develop but need the package number to be correct before it can be completed:

gui-cs/TerminalGuiDesigner#307

@AndrewSav
Copy link

Looks like removing gitversion might be the easiest solution, if it could take more time to find out how to make it behave. I also vote for prioritising solving this issue if it counts.

@tig
Copy link
Collaborator

tig commented Feb 18, 2025

I think I have fixed this.

v2_develop packages are now in the form of v2.0.0-develop.xxxx. NOTE the 'develop' not 'v2_develop'.:

Image

@tig
Copy link
Collaborator

tig commented Feb 19, 2025

Yep. Seems fixed.

Image

2.0.0-develop.1542 and 2.0.0-develop.1544 were from two different machines.

There's now a script in ./Scripts that will ease delisting old versions.

@tznind
Copy link
Collaborator Author

tznind commented Mar 17, 2025

This is happening again, see

Image

tznind added a commit to gui-cs/TerminalGuiDesigner that referenced this issue Mar 17, 2025
@tznind tznind moved this from ✅ Done to 🏗 Approved - In progress in Terminal.Gui V2 Initial Release Mar 17, 2025
@tznind tznind moved this from 🏗 Approved - In progress to 📋 Approved - Need Owner in Terminal.Gui V2 Initial Release Mar 17, 2025
@tig
Copy link
Collaborator

tig commented Mar 17, 2025

I think I know what I did. Should be a one time thing. I'll delist it asap.

@tig
Copy link
Collaborator

tig commented Mar 17, 2025

Fixed.

https://www.nuget.org/packages/Terminal.Gui

I need to remember to run dotnet gitversion before pushing to v2_develop to ensure gitversion is picking up the latest tag properly.

If this happens agan, I need to do

git tag v2.0.0-develop.4375 -a -m " v2.0.0-develop.4375"
git push --tags  upstream v2_develop

@tznind tznind closed this as completed Mar 17, 2025
@github-project-automation github-project-automation bot moved this from 📋 Approved - Need Owner to ✅ Done in Terminal.Gui V2 Initial Release Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug build-and-deploy Issues regarding to building and deploying Terminal.Gui v2 For discussions, issues, etc... relavant for v2
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants