Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a CI pipeline (perhaps ruff, pyright) #42

Open
KilowattSynthesis opened this issue Dec 19, 2024 · 2 comments
Open

Add a CI pipeline (perhaps ruff, pyright) #42

KilowattSynthesis opened this issue Dec 19, 2024 · 2 comments

Comments

@KilowattSynthesis
Copy link
Contributor

Just a heads up that the main branch (which you recommend installing from, in the README) is currently broken because the gear file is missing from typing import Optional (at commit 522732a).

It's been like that, unnoticed, for at least two days.

It would be nice if those sorts of issues were caught with standard checks on this repo. Would you be open to me submitting a PR which adds a standard linting and/or type check in a GitHub Action?

@gumyr
Copy link
Owner

gumyr commented Dec 19, 2024

In general bd_warehouse doesn't get enough of my time. I want to:

  • create unittests,
  • implement a CI pipeline (very similar to build123d), and
  • create a pypi release so a pip install bd_warehouse works.

If you're willing to help with this it would be greatly appreciated.

@KilowattSynthesis
Copy link
Contributor Author

Sure, I'd be happy to help with some of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants