Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some Questions about Metric Calculation and PU-GAN Dataset #10

Open
Cyprus-hy opened this issue Dec 26, 2021 · 3 comments
Open

Some Questions about Metric Calculation and PU-GAN Dataset #10

Cyprus-hy opened this issue Dec 26, 2021 · 3 comments

Comments

@Cyprus-hy
Copy link

Cyprus-hy commented Dec 26, 2021

Hi, thanks for your work. While I have some questions about metric calculation and PU-GAN dataset. The first one is the hausdorff distance, your implementation here seems not consistent with the definition, which means it should be calculated as follow: hd_value = np.max(A, B) but not hd_value = np.max(A+B). I also check the code in PU-GAN (here) and DIS-PU (here), it seems you all calculate this metric mistakenly. The second is the point-to-surface distance, it seems that you only calculate the unidirectional point-to-surface distance here , but not the symmetrical point-to-surface and surface-to-point distance, just as chamfer distance. And I think the symmetric calculation is more convincing. The third is that I find the test set of PU-GAN dataset only contains mesh file, so does it mean each paper using PU-GAN dataset generates the input point cloud file and groundtruth point cloud file by their own? If so, how do you generate the input and groundtruth test pair for PU-GAN dataset? I also notice your PU1K dataset provide test point cloud file, but the loss of test point cloud file in PU-GAN really makes me confused. Thanks a lot, hope for your reply.

@guochengqian
Copy link
Owner

@Cyprus-hy
Really. This is serious. When i worked on this project, i just took the evaluation code from MPU and PU-GAN. I did not expect the evaluation metric to be wrong.

@guochengqian
Copy link
Owner

@Cyprus-hy For the third question about the dataset, please give me some time. I am currently working on other projects. It will some time for me to work on your questions. However, i will work it as soon as I can.

@hay-001
Copy link

hay-001 commented Jul 21, 2022

@Cyprus-hy For the third question about the dataset, please give me some time. I am currently w
Hi, Did this question about Metric Calculation and PU-GAN Dataset be solved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants