Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve tensor_mul assertions #172

Closed
EmilyBourne opened this issue Mar 7, 2025 · 0 comments · Fixed by #174
Closed

Improve tensor_mul assertions #172

EmilyBourne opened this issue Mar 7, 2025 · 0 comments · Fixed by #174
Labels
enhancement New feature or request

Comments

@EmilyBourne
Copy link
Member

The tensor_mul operator does not verify that the indices operator on the same dimensions. E.g.:

DTensor<VectorIndexSet<X, Y>, VectorIndexSet<X, Y>> A;
DTensor<VectorIndexSet<R, Theta>> b;
tensor_mul(index<'i','j'>(A), index<'j'>(b));

should raise an error.
@EmilyBourne EmilyBourne added the enhancement New feature or request label Mar 7, 2025
@EmilyBourne EmilyBourne changed the title The Improve tensor_mul assertions Mar 7, 2025
EmilyBourne added a commit that referenced this issue Mar 7, 2025
@EmilyBourne
Add missing static_assert. Fixes #172. Improve error message
18efd5d
@EmilyBourne EmilyBourne mentioned this issue Mar 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve tensor_mul static assertions gyselax/gyselalibxx
1 participant
@EmilyBourne