Localize test setup and use ESM for tests

I wanted to run the controller test on its own, but it failed because
these env vars were set in the shell script. I started by adding a
setup.js file and importing it in all of the tests but then I realized
that we only need to do this in the controller test so I moved it there.

In the middle I ended up converting these files to ESM.

Author: lencioni

.eslintrc.js

@@ -19,7 +19,7 @@ module.exports = {
   ignorePatterns: ['pages/'],
   parserOptions: {
     sourceType: 'module',
-    ecmaVersion: 2018,
+    ecmaVersion: 2020,
   },
   rules: {
     'no-use-before-define': 2,

test/controller-test.js test/controller-test.mjs

@@ -1,8 +1,9 @@
-const { describe, it, before, after } = require('node:test');
-const fs = require('fs');
-const path = require('path');
-const assert = require('assert');
-const Controller = require('../controller');
+import fs from 'node:fs';
+import path from 'node:path';
+import assert from 'node:assert';
+import { describe, it, before, after } from 'node:test';
+
+import Controller from '../controller.js';
 
 const mockHappoConfig = {
   apiKey: 'test-api-key',
@@ -15,9 +16,17 @@ const mockHappoConfig = {
   },
 };
 
-const mockHappoConfigPath = path.join(__dirname, '..', '.happo.js');
+const mockHappoConfigPath = path.join(import.meta.dirname, '..', '.happo.js');
+
+let originalEnv = {
+  HAPPO_ENABLED: process.env.HAPPO_ENABLED,
+  HAPPO_E2E_PORT: process.env.HAPPO_E2E_PORT,
+};
 
 before(() => {
+  process.env.HAPPO_ENABLED = true;
+  process.env.HAPPO_E2E_PORT = 3000;
+
   // Create a mock happo.js file
   fs.writeFileSync(
     mockHappoConfigPath,
@@ -26,6 +35,10 @@ before(() => {
 });
 
 after(() => {
+  for (const [key, value] of Object.entries(originalEnv)) {
+    process.env[key] = value;
+  }
+
   // Clean up the mock config
   fs.unlinkSync(mockHappoConfigPath);
 });

test/createAssetPackage-test.js test/createAssetPackage-test.mjs

@@ -1,15 +1,14 @@
-const { describe, it } = require('node:test');
-const assert = require('assert');
-const fs = require('fs');
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
+import fs from 'node:fs';
+import http from 'node:http';
+import handler from 'serve-handler';
 
-const createAssetPackage = require('../src/createAssetPackage');
+import createAssetPackage from '../src/createAssetPackage.js';
 
 const { SAVE_PACKAGE } = process.env;
 
 async function wrap(func) {
-  const handler = require('serve-handler');
-  const http = require('http');
-
   const server = http.createServer((request, response) => {
     return handler(request, response, { public: 'test-fixtures' });
   });

test/findCSSAssetUrls-test.js test/findCSSAssetUrls-test.mjs

@@ -1,7 +1,7 @@
-const { describe, it } = require('node:test');
-const assert = require('assert');
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
 
-const findCSSAssetUrls = require('../src/findCSSAssetUrls');
+import findCSSAssetUrls from '../src/findCSSAssetUrls.js';
 
 describe('findCSSAssetUrls', () => {
   it('finds asset urls in CSS', () => {

test/makeAbsolute-test.js test/makeAbsolute-test.mjs

@@ -1,7 +1,7 @@
-const { describe, it } = require('node:test');
-const assert = require('node:assert');
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
 
-const makeAbsolute = require('../src/makeAbsolute');
+import makeAbsolute from '../src/makeAbsolute.js';
 
 const baseUrl = 'https://base.url';
 

test/makeExternalUrlsAbsolute-test.js test/makeExternalUrlsAbsolute-test.mjs

@@ -1,7 +1,7 @@
-const { describe, it } = require('node:test');
-const assert = require('assert');
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
 
-const makeExternalUrlsAbsolute = require('../src/makeExternalUrlsAbsolute');
+import makeExternalUrlsAbsolute from '../src/makeExternalUrlsAbsolute.js';
 
 const resourceUrl = 'https://base.url/styles/styles.min.css';
 

test/resolveEnvironment-test.js test/resolveEnvironment-test.mjs

@@ -1,7 +1,7 @@
-const { describe, it } = require('node:test');
-const path = require('path');
-const assert = require('assert');
-const resolveEnvironment = require('../src/resolveEnvironment');
+import { describe, it } from 'node:test';
+import path from 'node:path';
+import assert from 'node:assert';
+import resolveEnvironment from '../src/resolveEnvironment.js';
 
 describe('resolveEnvironment', () => {
   it('resolves the dev environment', () => {
@@ -117,7 +117,10 @@ describe('resolveEnvironment', () => {
   it('resolves the GitHub Actions environment', () => {
     const githubEnv = {
       GITHUB_SHA: 'ccddffddccffdd',
-      GITHUB_EVENT_PATH: path.resolve(__dirname, 'github_pull_request_event.json'),
+      GITHUB_EVENT_PATH: path.resolve(
+        import.meta.dirname,
+        'github_pull_request_event.json',
+      ),
     };
     let result = resolveEnvironment(githubEnv);
     assert.equal(result.beforeSha, 'f95f852bd8fca8fcc58a9a2d6c842781e32a215e');
@@ -126,7 +129,10 @@ describe('resolveEnvironment', () => {
     assert.equal(result.message, 'Update the README with new information.');
 
     // Try with a push event
-    githubEnv.GITHUB_EVENT_PATH = path.resolve(__dirname, 'github_push_event.json');
+    githubEnv.GITHUB_EVENT_PATH = path.resolve(
+      import.meta.dirname,
+      'github_push_event.json',
+    );
     result = resolveEnvironment(githubEnv);
     assert.equal(result.beforeSha, '6113728f27ae82c7b1a177c8d03f9e96e0adf246');
     assert.equal(result.afterSha, '0000000000000000000000000000000000000000');
@@ -138,7 +144,7 @@ describe('resolveEnvironment', () => {
 
     // Try with a workflow_dispatch event
     githubEnv.GITHUB_EVENT_PATH = path.resolve(
-      __dirname,
+      import.meta.dirname,
       'github_workflow_dispatch.json',
     );
     result = resolveEnvironment(githubEnv);
@@ -170,7 +176,10 @@ describe('resolveEnvironment', () => {
   it('resolves the GitHub merge group environment', () => {
     const githubEnv = {
       GITHUB_SHA: 'ccddffddccffdd',
-      GITHUB_EVENT_PATH: path.resolve(__dirname, 'github_merge_group_event.json'),
+      GITHUB_EVENT_PATH: path.resolve(
+        import.meta.dirname,
+        'github_merge_group_event.json',
+      ),
     };
     let result = resolveEnvironment(githubEnv);
     assert.equal(result.beforeSha, 'f95f852bd8fca8fcc58a9a2d6c842781e32a215e');

test/takeDOMSnapshot-test.js test/takeDOMSnapshot-test.mjs

@@ -1,8 +1,8 @@
-const { describe, it } = require('node:test');
-const assert = require('assert');
-const jsdom = require('jsdom');
+import { describe, it } from 'node:test';
+import assert from 'node:assert';
+import jsdom from 'jsdom';
 
-const takeDOMSnapshot = require('../takeDOMSnapshot');
+import takeDOMSnapshot from '../takeDOMSnapshot.js';
 
 describe('takeDOMSnapshot', () => {
   it('takes a basic snapshot', () => {