Fix regex in _parse_additional_config() (#1868)

hardbyte · Oct 7, 2024 · c5c18dc · c5c18dc
1 parent d4f3954
commit c5c18dc
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/can/logger.py b/can/logger.py
@@ -145,7 +145,7 @@ def __call__(
 
 def _parse_additional_config(unknown_args: Sequence[str]) -> TAdditionalCliArgs:
     for arg in unknown_args:
-        if not re.match(r"^--[a-zA-Z\-]*?=\S*?$", arg):
+        if not re.match(r"^--[a-zA-Z][a-zA-Z0-9\-]*=\S*?$", arg):
             raise ValueError(f"Parsing argument {arg} failed")
 
     def _split_arg(_arg: str) -> Tuple[str, str]:

diff --git a/test/test_logger.py b/test/test_logger.py
@@ -146,6 +146,7 @@ def test_parse_additional_config(self):
             "--receive-own-messages=True",
             "--false-boolean=False",
             "--offset=1.5",
+            "--tseg1-abr=127",
         ]
         parsed_args = can.logger._parse_additional_config(unknown_args)
 
@@ -170,6 +171,9 @@ def test_parse_additional_config(self):
         assert "offset" in parsed_args
         assert parsed_args["offset"] == 1.5
 
+        assert "tseg1_abr" in parsed_args
+        assert parsed_args["tseg1_abr"] == 127
+
         with pytest.raises(ValueError):
             can.logger._parse_additional_config(["--wrong-format"])