Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Ungroup selected" to remove a title from a series does not work as expected #1696

Open
lizadaly opened this issue Aug 9, 2022 · 0 comments

Comments

@lizadaly
Copy link
Contributor

lizadaly commented Aug 9, 2022

Easiest to explain by reproduction case:

  • Have 3 published casebooks in your dashboard
  • Go to the user dashboard and select Manage Casebooks
  • Add 3 books to a series by grouping them
  • Select 1 book, click "Ungroup selected"
  • Observe that two books move to ungrouped!

What seems to be happening behind the scenes is that upon clicking "Ungroup selected", the front end sends a POST request to /api/titles/<series-id> with a payload of only the current title, and the serializer happily updates the CommonTitle object to match. This seems to be the effect whether you choose the current title to ungroup or not.

I'm pretty sure this has the effect of always removing all titles from a series, no matter how many are in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant