Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kv-builder: Builder.add() mishandles filenames with equals ('=') signs #5

Open
arusso opened this issue Aug 9, 2021 · 0 comments
Open

Comments

@arusso
Copy link

arusso commented Aug 9, 2021

Problem

When Builder.add() is called, it is splitting the values on = to look for key/value pairs. This doesn't take into account that = is a valid character for a filename, and will mishandle files containing that character. An example of such a case can be seen in vault#12290

Expected Result

When Builder.add(string) encounters a raw value such as @cn=foo,o=example.com.json then it should read k/v from file cn=foo,o=example.com.json and not set {"@cn": "foo,o=example.com.json"}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant