Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad-pack throws obtuse error when pack does not contain a parent template #510

Open
attachmentgenie opened this issue May 3, 2024 · 1 comment

Comments

@attachmentgenie
Copy link
Contributor

attachmentgenie commented May 3, 2024

Due to a copy and past error we had some trouble getting a pack running. By mistake it didnt have a *.nomad.tpl file but merely all *.tpl files

❯ nomad-pack version
Nomad Pack v0.1.1 (5159a77)

reproduce

❯ nomad-pack generate pack foo
❯ nomad-pack {plan,render,run,destroy} foo

The workflow above works as expected now rename the foo.nomad.tpl file to foo.tpl and than plan or run (render actually still works as expected)

`
❯ mv foo/templates/foo.nomad.tpl foo/templates/foo.tpl
❯ nomad-pack render foo <- shows job output correctly
❯ nomad-pack plan foo
! No Templates Rendered

Error:   no templates were rendered by the renderer process run
Context: 
    - Registry Name: <<local folder>>
    - Pack Name: foo
    - Pack Ref: <<none>>
    - Pack Path: /home/attachmentgenie/DevShed/StufisGeneralis/foo
    - Deployment Name: foo

`
The error presented isnt very clear as to what is actually happening or what nomad-pack is complaining about

@angrycub
Copy link
Contributor

angrycub commented Jun 5, 2024

Right, this makes sense, because pack needs the extension to know which outputs plannable job specifications that can be planned. Since the job template lacked an extension, it gets rendered as a non-job template. I'll see about improving this error message so that it is clearer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants