Batch jobs added to detail-restart test loop

ui/app/templates/components/job-page/parts/title.hbs

@@ -103,7 +103,7 @@
           />
         {{else if
           (and
-            (or (eq this.job.type "batch") (eq this.job.type "system") (eq this.job.type "sysbatch"))
+            (not this.job.hasVersionStability)
             this.job.latestVersion
           )
         }}

ui/mirage/scenarios/default.js

@@ -1250,6 +1250,15 @@ export function createRestartableJobs(server) {
     type: 'service',
   });
 
+  const revertableBatchJob = server.create('job', {
+    name: 'revertable-batch-job',
+    stopped: false,
+    status: 'dead',
+    noDeployments: true,
+    shallow: true,
+    type: 'batch',
+  });
+
   // So it shows up as "Failed" instead of "Scaled Down"
   restartableJob.taskGroups.models[0].update({
     count: 1,
@@ -1274,6 +1283,10 @@ export function createRestartableJobs(server) {
     .all()
     .filter((v) => v.jobId === nonRevertableJob.id)
     .models.forEach((v) => v.destroy());
+  server.schema.jobVersions
+    .all()
+    .filter((v) => v.jobId === revertableBatchJob.id)
+    .models.forEach((v) => v.destroy());
 
   server.create('job-version', {
     job: revertableJob,
@@ -1324,6 +1337,22 @@ export function createRestartableJobs(server) {
     noActiveDeployment: true,
   });
 
+  server.create('job-version', {
+    job: revertableBatchJob,
+    namespace: revertableBatchJob.namespace,
+    version: 0,
+    stable: false, // <--- ignored by the UI by way of job.hasVersionStability
+    noActiveDeployment: true,
+  });
+
+  server.create('job-version', {
+    job: revertableBatchJob,
+    namespace: revertableBatchJob.namespace,
+    version: 1,
+    stable: false, // <--- ignored by the UI by way of job.hasVersionStability
+    noActiveDeployment: true,
+  });
+
   server.schema.jobVersions
     .all()
     .filter((v) => v.jobId === revertableJob.id)

ui/tests/acceptance/job-detail-test.js

@@ -848,6 +848,15 @@ module('Job Start/Stop/Revert/Edit and Resubmit', function (hooks) {
     assert.ok(JobDetail.editAndResubmit.isPresent);
   });
 
+  test('A batch job with a previous version can be reverted', async function (assert) {
+    const revertableSystemJob = server.db.jobs.findBy(
+      (j) => j.name === 'revertable-batch-job'
+    );
+    await JobDetail.visit({ id: revertableSystemJob.id });
+    assert.ok(JobDetail.revert.isPresent);
+    assert.equal(JobDetail.revert.text, 'Revert to last stable version (v0)');
+  });
+
   test('Clicking the resubmit button navigates to the job definition page in edit mode', async function (assert) {
     const job = server.db.jobs.findBy((j) => j.name === 'non-revertable-job');
     await JobDetail.visit({ id: job.id });