Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI - Versions - Revert Version improvements #24156

Closed
davidlublink opened this issue Oct 9, 2024 · 2 comments · Fixed by #24168
Closed

UI - Versions - Revert Version improvements #24156

davidlublink opened this issue Oct 9, 2024 · 2 comments · Fixed by #24168

Comments

@davidlublink
Copy link

Proposal

I propose changing the way the 'Revert Version' function works in the Nomad UI:

image

In it's current form, when I click 'Revert Version' it asks for confirmation and submits the changes.

I would like a new button 'Edit this version in the plan UI' where it would take the version selected and drop it into the 'Plan Job' UI. From here, I could make changes to the job before submitting, these changes could include changing the name of the job(thus cloning from an old version ).

Use-cases

  1. I have an older version of a job I want to return to without affecting the running allocations, I press the button give the job a new name and possibly tweak some parameters before submitting
  2. I want to run an old version of the job on a different cluster(maybe a testing cluster), if I click this button when I land on the 'Plan Job' page, I can copy the entire content out to the different cluster without having to reconstruct the job manually from the diff and the current version.

Attempted Solutions

  1. Revert to the version I want to investigate
  2. Go copy the definition from the definition page
  3. Revert the job back to the pre-reverted state in step 1
  4. Modify the job in an external editor
  5. Submit the job

The issue with this solution is the active allocations might be destroyed as a result of the 'Revert version' and so the operator has to break services to return to this older version.

@philrenaud
Copy link
Contributor

Hey @davidlublink, this is a fantastic suggestion. We have a few changes to the versions page coming up soon, and this is a good opportunity to expand on those as well. I'll make a point to dig into this soon.

@philrenaud
Copy link
Contributor

Hi @davidlublink , wanted to reach out and thank you again for this suggestion. We added "Clone as new version" and "Clone as new job" options to version blocks on this page, and I hope they satisfy your requirements here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants