Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic host volumes: capabilities check during scheduling #24617

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

tgross
Copy link
Member

@tgross tgross commented Dec 6, 2024

Static host volumes have a simple readonly toggle, but dynamic host volumes have a more complex set of capabilities similar to CSI volumes. Update the feasibility checker to account for these capabilities and volume readiness.

Also fixes a minor bug in the state store where a soft-delete (not yet implemented) could cause a volume to be marked ready again. This is needed to support testing the readiness checking in the scheduler.

Ref: #24479

Static host volumes have a simple readonly toggle, but dynamic host volumes have
a more complex set of capabilities similar to CSI volumes. Update the
feasibility checker to account for these capabilities and volume readiness.

Also fixes a minor bug in the state store where a soft-delete (not yet
implemented) could cause a volume to be marked ready again. This is needed to
support testing the readiness checking in the scheduler.

Ref: #24479
@tgross tgross force-pushed the dhv-scheduling-capabilities branch from a15a895 to 46cf4cc Compare December 10, 2024 14:56
@tgross tgross added this to the 1.10.0 milestone Dec 10, 2024
@tgross tgross marked this pull request as ready for review December 10, 2024 14:57
@tgross tgross requested review from a team as code owners December 10, 2024 14:57
Copy link
Contributor

@pkazmierczak pkazmierczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for doing this Tim

@tgross tgross merged commit 57f46d5 into dynamic-host-volumes Dec 10, 2024
23 checks passed
@tgross tgross deleted the dhv-scheduling-capabilities branch December 10, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants