Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stateful deployments: task group host volume claims API #25114

Merged
merged 19 commits into from
Feb 25, 2025
Merged

stateful deployments: task group host volume claims API #25114

merged 19 commits into from
Feb 25, 2025

Conversation

pkazmierczak
Copy link
Contributor

@pkazmierczak pkazmierczak commented Feb 13, 2025 •
edited
Loading

This PR introduces API endpoints /v1/volumes/claims/ and /v1/volumes/claim/:id for listing and deleting task group host volume claims, respectively.

@pkazmierczak pkazmierczak self-assigned this Feb 13, 2025
@pkazmierczak pkazmierczak added this to the 1.10.0 milestone Feb 13, 2025
@pkazmierczak pkazmierczak marked this pull request as ready for review February 14, 2025 13:21
@pkazmierczak pkazmierczak requested review from a team as code owners February 14, 2025 13:21
@pkazmierczak pkazmierczak requested a review from a team as a code owner February 14, 2025 13:42
@pkazmierczak pkazmierczak force-pushed the f-stateful-deployments-claims-api branch from 1fdd734 to 81b0901 Compare February 14, 2025 14:05
tgross
tgross reviewed Feb 14, 2025
View reviewed changes
@pkazmierczak pkazmierczak requested a review from tgross February 14, 2025 17:03
tgross
tgross reviewed Feb 14, 2025
View reviewed changes
aimeeu
aimeeu reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@aimeeu aimeeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs. I left a few style guide suggestions.

@aimeeu aimeeu added the theme/docs Documentation issues and enhancements label Feb 20, 2025
@pkazmierczak pkazmierczak requested a review from tgross February 24, 2025 20:06
tgross
tgross requested changes Feb 24, 2025
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good overall. We mostly need to get the filtering logic fixed up.

tgross
tgross reviewed Feb 25, 2025
View reviewed changes
tgross
tgross approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkazmierczak pkazmierczak merged commit 58c6387 into main Feb 25, 2025
33 checks passed
@pkazmierczak pkazmierczak deleted the f-stateful-deployments-claims-api branch February 25, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aimeeu aimeeu aimeeu left review comments

@tgross tgross tgross approved these changes

@gulducat gulducat Awaiting requested review from gulducat

Assignees

@pkazmierczak pkazmierczak

Labels
theme/docs Documentation issues and enhancements
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@pkazmierczak @tgross @aimeeu