Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListProcesses through PID when cgroup is not found in Linux #25198

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simon1990zcs
Copy link

Description

when nomad is running rootless in linux, it fails to output CPU and memory metrics.
Specifically speaking, actually it fails to read associated PIDs in this scenerios, which leads to zero for all downstream operations.
When cgroup == OFF, where rooless client fails into this category, we should fallback to classic list PIds through executor pid.

Testing & Reproduction steps

the reproduction test of the bug: #20285

Links

#20285
#19828

Contributor Checklist

  • Changelog Entry If this PR changes user-facing behavior, please generate and add a
    changelog entry using the make cl command.
  • Testing Please add tests to cover any new functionality or to demonstrate bug fixes and
    ensure regressions will be caught.
  • Documentation If the change impacts user-facing functionality such as the CLI, API, UI,
    and job configuration, please update the Nomad website documentation to reflect this. Refer to
    the website README for docs guidelines. Please also consider whether the
    change requires notes within the upgrade guide.

Reviewer Checklist

  • Backport Labels Please add the correct backport labels as described by the internal
    backporting document.
  • Commit Type Ensure the correct merge method is selected which should be "squash and merge"
    in the majority of situations. The main exceptions are long-lived feature branches or merges where
    history should be preserved.
  • Enterprise PRs If this is an enterprise only PR, please add any required changelog entry
    within the public repository.

@simon1990zcs simon1990zcs requested review from a team as code owners February 23, 2025 20:22
Copy link

hashicorp-cla-app bot commented Feb 23, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant