deps: update go-msgpack and net-rpc-msgpackrpc #25201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where connections would not be closed on write errors in the msgpack encoder, which would cause the reader end of RPC connections to hang indefinitely. This resulted in clients in widely-distributed geographies being unable to poll for allocation updates. Fixes: #23305
gulducat
approved these changes
Feb 24, 2025
| @@ -64,7 +64,7 @@ require ( | |||
| github.com/hashicorp/go-kms-wrapping/wrappers/transit/v2 v2.0.12 | |||
| github.com/hashicorp/go-memdb v1.3.4 | |||
| github.com/hashicorp/go-metrics v0.5.4 | |||
| github.com/hashicorp/go-msgpack/v2 v2.1.2 | |||
| github.com/hashicorp/go-msgpack/v2 v2.1.3 | |||
There was a problem hiding this comment.
for posterity, the relevant change here is hashicorp/go-msgpack#26, which is theorized to be no-op, but "just in case", yes?
| @@ -80,7 +80,7 @@ require ( | |||
| github.com/hashicorp/hcl/v2 v2.20.2-0.20240517235513-55d9c02d147d | |||
| github.com/hashicorp/hil v0.0.0-20210521165536-27a72121fd40 | |||
| github.com/hashicorp/memberlist v0.5.3 | |||
| github.com/hashicorp/net-rpc-msgpackrpc/v2 v2.0.0 | |||
| github.com/hashicorp/net-rpc-msgpackrpc/v2 v2.0.1 | |||
There was a problem hiding this comment.
and hashicorp/net-rpc-msgpackrpc#15, which does matter, and fixes the issue.
tgross
added a commit
that referenced
this pull request
Feb 24, 2025
Fixes a bug where connections would not be closed on write errors in the msgpack encoder, which would cause the reader end of RPC connections to hang indefinitely. This resulted in clients in widely-distributed geographies being unable to poll for allocation updates. Fixes: #23305
|
Backported to:
This was not backported to 1.7.x+ent because that version of Nomad is using the v1 versions of go-msgpack and net-rpc-msgpackrpc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where connections would not be closed on write errors in the msgpack encoder, which would cause the reader end of RPC connections to hang indefinitely. This resulted in clients in widely-distributed geographies being unable to poll for allocation updates.
Fixes: #23305