-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: improve cross-links for scheduler preemption #25203
Conversation
Fix a broken link from the preemption concepts docs to the relevant API. Also include a link to the relevant command. Ref: #25038
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tim!
Hi. I am not so experienced, thus I'll highlight parts that are not so clear for me:
The link above has nothing about scheduler. We need to click two pages deeper to find interested information. It would be better to put direct link to the information for Please note, that this part does not say that this scheduler is enabled by default. But this part https://developer.hashicorp.com/nomad/docs/concepts/scheduling/preemption#details mentions that: As you commented here It looks like system jobs do not have enabled by default preemption.
It would be worth to extend this example to show that if preemption for Thanks. |
That's literally what this PR does, mate. Look at the diff or the preview: |
@tgross I checked the diff, but that format was not so clear. But this still does not documents that this option is enabled by default: https://developer.hashicorp.com/nomad/docs/commands/operator/scheduler/set-config#preempt-system-scheduler
|
Fix a broken link from the preemption concepts docs to the relevant API. Also include a link to the relevant command. Ref: #25038
… (#25207) Fix a broken link from the preemption concepts docs to the relevant API. Also include a link to the relevant command. Ref: #25038 Co-authored-by: Tim Gross <[email protected]>
@tgross Broken link about schedulers: https://developer.hashicorp.com/nomad/docs/configuration/server#default_scheduler_config Also it would be nice to have a full list of possible values that could be configured here: https://developer.hashicorp.com/nomad/docs/configuration/server#enabled_schedulers |
@EugenKon PRs welcome |
So https://developer.hashicorp.com/nomad/docs/configuration/server#enabled_schedulers |
Fix a broken link from the preemption concepts docs to the relevant API. Also include a link to the relevant command.
Ref: #25038
Preview link: https://nomad-m6t6tq8jc-hashicorp.vercel.app/nomad/docs/concepts/scheduling/preemption#details