Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Repo]: Update actions-ecosystem/actions-remove-labels to support NodeJS 16 #30814

Closed
maunzCache opened this issue Apr 19, 2023 · 5 comments · Fixed by #31750
Closed

[Repo]: Update actions-ecosystem/actions-remove-labels to support NodeJS 16 #30814

maunzCache opened this issue Apr 19, 2023 · 5 comments · Fixed by #31750
Labels
github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog.
Milestone

Comments

@maunzCache
Copy link

Description

When commenting on issues or PR, Github will trigger some workflows for the user. Even though those actions finish, i got warnings for them like this:

issue_comment_triage
Error: failed to remove labels: stale,waiting-response

issue_comment_triage
Node.js 12 actions are deprecated. Please update the following actions to use Node.js 16: actions-ecosystem/action-remove-labels@2ce5d41. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/.

issue_comment_triage
failed to remove label: stale: HttpError: Label does not exist

issue_comment_triage
failed to remove label: waiting-response: HttpError: Label does not exist

While the first message is a valid error, the others are a warning. I'd take the second one as recommendation to update the referenced action in https://github.com/hashicorp/terraform-provider-aws/blob/main/.github/workflows/community-comment.yml

References

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

Would you like to implement a fix?

None

@maunzCache maunzCache added needs-triage Waiting for first response or review from a maintainer. repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog. labels Apr 19, 2023
@github-actions
Copy link

Community Note

Voting for Prioritization

  • Please vote on this issue by adding a 👍 reaction to the original post to help the community and maintainers prioritize this request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

Volunteering to Work on This Issue

  • If you are interested in working on this issue, please leave a comment.
  • If this would be your first contribution, please review the contribution guide.

@maunzCache
Copy link
Author

Just understood what the error was. This issue is blocked by actions-ecosystem/action-remove-labels#413

@SarahFrench
Copy link
Member

This work may help with this issue: hashicorp/terraform-provider-vsphere#1914
Either as inspiration or something to copy over (once it's reviewed)

@justinretzolk justinretzolk added github_actions Pull requests that update Github_actions code and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2023
@github-actions github-actions bot added this to the v5.2.0 milestone Jun 8, 2023
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

This functionality has been released in v5.2.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
github_actions Pull requests that update Github_actions code repository Repository modifications; GitHub Actions, developer docs, issue templates, codeowners, changelog.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants