Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Favicon is missing #52

Open
chreekat opened this issue Nov 26, 2024 · 1 comment
Open

Favicon is missing #52

chreekat opened this issue Nov 26, 2024 · 1 comment

Comments

@chreekat
Copy link

Q A
Test page https://wiki.haskell.org/index.php?title=Haskell
Attempted favicon url https://wiki.haskell.org/index.php?title=Favicon.ico
href as generated in the source /favicon.ico

Cause

The cause is that $wgFavicon is not set, and the default value is /favicon.ico. Since we've enabled short urls (and because that file doesn't exist?), it is interpreted as an article title, and the "article" doesn't exist.

image

Alternatives

Build /wikistatic

The old site had a /wikistatic route, and $wgFavicon was set to /wikistatic/favicon.ico.

Do we need the rest of the /wikistatic machinery? If so, we should replicate it.

Plop the favicon.ico in the right spot

Maybe there's already somewhere to put it that it'll get picked up?

@hgolden
Copy link
Collaborator

hgolden commented Nov 26, 2024

The old site's configuration worked. I suggest replicating it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants