Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graphqurl 1.0.3 reported older punycode library is used and forcing to use older NodeJS versions #150

Open
Kashish3009 opened this issue Nov 11, 2024 · 5 comments

Comments

@Kashish3009
Copy link

Problem Description:

graphqurl 1.0.3 and reports that punycode library used here is outdated and it forces them to use Node 19 (older version) where someone is using later versions of NodeJs

Proposal:

To update the repository to use latest Punycode library.

Output:

Output of yarn why punycode -R

graphqurl@npm:1.0.3 (via npm:^1.0.3)
│ ├─ graphql-language-service-interface@npm:2.10.2 [36882] (via npm:^2.8.2 [36882])
│ │ ├─ graphql-config@npm:4.5.0 [d912b] (via npm:^4.1.0 [d912b])
│ │ │ └─ @graphql-tools/url-loader@npm:7.17.18 [422a5] (via npm:^7.9.7 [422a5])
│ │ │ ├─ @whatwg-node/fetch@npm:0.8.8 (via npm:^0.8.0)
│ │ │ │ └─ @whatwg-node/node-fetch@npm:0.3.6 (via npm:^0.3.6)
│ │ │ │ └─ fast-url-parser@npm:1.1.3 (via npm:^1.1.3)
│ │ │ │ └─ punycode@npm:1.4.1 (via npm:^1.3.2)

@manasag
Copy link
Contributor

manasag commented Nov 15, 2024

Thanks for opening the issue. Looking into this.

@spr-mweber3
Copy link

@manasag Thanks for responding. Having the same issue here.

@manasag
Copy link
Contributor

manasag commented Nov 27, 2024

I have spent some time looking into this issue. This requires a lot of work at this stage to make this fully work with latest nodejs. The primary blocker is coming from the embedded GraphiQL UI (which runs via gql endpoint -i). It's is a very old modified version of GraphiQL, and the only way to make that work is to replace with newer versions of GraphiQL with similar modifications. This is a large undertaking.
If we remove the GraphiQL feature and focus only on the CLI and library, then its much smaller codebase to upgrade. I am going to create a new branch of graphqurl with GraphiQL feature disabled and tag it with a different version. This should help users who are ONLY interested in graphqurl as CLI for query execution on terminal and a graphql client. I should be able to release this in next couple of days.

@manasag
Copy link
Contributor

manasag commented Nov 27, 2024

Ok, so I am able to release 2.0.0 as described above. Here is the PR for reference.

@spr-mweber3
Copy link

@manasag Sounds reasonable! Would work for me. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants