Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation of examples #235

Open
PanderMusubi opened this issue Jun 29, 2022 · 6 comments
Open

Validation of examples #235

PanderMusubi opened this issue Jun 29, 2022 · 6 comments
Assignees
Labels
Milestone

Comments

@PanderMusubi
Copy link
Collaborator Author

@greyli most of the feedback is regarding Element a not allowed as child of element ul in this context. inside navigation. How can we improve this?

@greyli greyli removed their assignment Feb 12, 2023
@PanderMusubi
Copy link
Collaborator Author

This validation can also be done locally in Firefox with the development tools. Open with Ctrl+Shift+C and choose the tab HTML validator.

@PanderMusubi
Copy link
Collaborator Author

PanderMusubi commented Feb 23, 2025

This can be run from the command line with

cd /tmp
wget https://github.com/validator/validator/releases/download/latest/vnu.jar
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/form
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/nav
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/bootswatch
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/pagination
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/flash
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/table
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/icon
java -jar vnu.jar https://bootstrap-flask-example.azurewebsites.net/icons

Is it okay to put this in a script that is part of the repo? @greyli

PS Currently there is a problem with https://bootstrap-flask-example.azurewebsites.net/icon

@PanderMusubi PanderMusubi modified the milestones: 2.2.0, 3.0 Feb 23, 2025
@PanderMusubi PanderMusubi self-assigned this Feb 23, 2025
@greyli
Copy link
Member

greyli commented Feb 24, 2025

Why do we need to validate the HTML of the example application?

For the 500 error, I prefer to add unit test to the examples.

@PanderMusubi
Copy link
Collaborator Author

It gives users a nicer starting point and might expose errors in our macros.

@greyli
Copy link
Member

greyli commented Feb 24, 2025

I see. You could add a GitHub Actions workflow to run the scripts above when changes are made to the examples folder. Be sure to update the URL to the local URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants