From 7a13a21e1163a051772e4c2f016721b9af720610 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D5=A1=C9=A8=D5=BC=C9=A2=D3=84=D5=A1=D6=85=D5=BC=C9=A2?= Date: Wed, 27 Mar 2024 12:15:41 +0800 Subject: [PATCH 1/2] fix(checkbox): incorrect onChange typing in Checkbox Group --- .changeset/heavy-berries-sniff.md | 5 +++++ packages/components/checkbox/src/use-checkbox-group.ts | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) create mode 100644 .changeset/heavy-berries-sniff.md diff --git a/.changeset/heavy-berries-sniff.md b/.changeset/heavy-berries-sniff.md new file mode 100644 index 0000000000..4cc8ca043b --- /dev/null +++ b/.changeset/heavy-berries-sniff.md @@ -0,0 +1,5 @@ +--- +"@nextui-org/checkbox": patch +--- + +Fixed incorrect onChange typing in Checkbox Group diff --git a/packages/components/checkbox/src/use-checkbox-group.ts b/packages/components/checkbox/src/use-checkbox-group.ts index 0272cd9682..b2d6bb1f00 100644 --- a/packages/components/checkbox/src/use-checkbox-group.ts +++ b/packages/components/checkbox/src/use-checkbox-group.ts @@ -14,7 +14,7 @@ import {clsx, safeAriaLabel} from "@nextui-org/shared-utils"; import {CheckboxProps} from "./index"; -interface Props extends HTMLNextUIProps<"div"> { +interface Props extends Omit, "onChange"> { /** * Ref to the DOM node. */ @@ -44,6 +44,10 @@ interface Props extends HTMLNextUIProps<"div"> { * React aria onChange event. */ onValueChange?: AriaCheckboxGroupProps["onChange"]; + /** + * Handler that is called when the value changes. + */ + onChange?: (values: string[]) => void; } export type UseCheckboxGroupProps = Props & From 263953e9d4f5b346eeadcaad62161af64a0b6c7e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=D5=A1=C9=A8=D5=BC=C9=A2=D3=84=D5=A1=D6=85=D5=BC=C9=A2?= Date: Wed, 27 Mar 2024 23:02:03 +0800 Subject: [PATCH 2/2] fix(checkbox): remove onChange from Props instead --- packages/components/checkbox/src/use-checkbox-group.ts | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/components/checkbox/src/use-checkbox-group.ts b/packages/components/checkbox/src/use-checkbox-group.ts index b2d6bb1f00..a29e3c96b7 100644 --- a/packages/components/checkbox/src/use-checkbox-group.ts +++ b/packages/components/checkbox/src/use-checkbox-group.ts @@ -14,7 +14,7 @@ import {clsx, safeAriaLabel} from "@nextui-org/shared-utils"; import {CheckboxProps} from "./index"; -interface Props extends Omit, "onChange"> { +interface Props extends HTMLNextUIProps<"div"> { /** * Ref to the DOM node. */ @@ -44,13 +44,9 @@ interface Props extends Omit, "onChange"> { * React aria onChange event. */ onValueChange?: AriaCheckboxGroupProps["onChange"]; - /** - * Handler that is called when the value changes. - */ - onChange?: (values: string[]) => void; } -export type UseCheckboxGroupProps = Props & +export type UseCheckboxGroupProps = Omit & AriaCheckboxGroupProps & Partial< Pick<