-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to markdown-it #52
base: master
Are you sure you want to change the base?
Conversation
and update other plugins
Ready to be merged :) |
I think maybe no problem if we switch the default markdown parser from marked to markdown-it. |
Understood. The main reason is that marked has some security issues that markdown-it does not have. There is no sanitizer in marked. You have to add it on top. But by default, markdown-it is safe |
Personally, I prefer Also, we need to compare the differences between the output from hexo-renderer-marked and the output from hexo-renderer-markdown-it, to see if it is potentially a breaking change that breaks new users (especially with existing themes). And if there is any, we should defer it to Hexo 7.0.0. That's to say, I am not against hexo-renderer-markdown-it, but more tests and preparations need to be done. |
There is one. https://github.com/hexojs/hexo-renderer-marked#options Autolink in marked will convert full url while the same feature in markdown-it will also convert urls |
and update other plugins
Following security issue on hexo-renderer-marked: hexojs/hexo-renderer-marked#210