HP-2335 Enhance exception handling to ensure code continues running smoothly if there are unexpected issues. (#299)

* HP-2335 Enhance exception handling to ensure code continues running smoothly if there are unexpected issues.

* HP-2335 modernized WaitHelper class

Author: VadymHrechukha

tests/_support/Helper/WaitHelper.php

@@ -10,25 +10,59 @@
 
 namespace hipanel\tests\_support\Helper;
 
+use Codeception\TestInterface;
+
 class WaitHelper extends \Codeception\Module
 {
+    private $webDriver = null;
+    private $webDriverModule = null;
+
     /**
      * @var int Default delay to wait while page updating
      */
-    protected int $defaultDelay = 5;
+    protected int $defaultDelay = 1;
+
+    public function _before(TestInterface $test)
+    {
+        if (!$this->hasModule('WebDriver') && !$this->hasModule('Selenium2')) {
+            throw new \Exception('PageWait uses the WebDriver. Please be sure that this module is activated.');
+        }
+
+        // Use WebDriver
+        if ($this->hasModule('WebDriver')) {
+            $this->webDriverModule = $this->getModule('WebDriver');
+            $this->webDriver = $this->webDriverModule->webDriver;
+        }
+    }
 
     /**
      * @param int $timeOut
      * @throws \Codeception\Exception\ModuleException
      */
-    public function waitForPageUpdate($timeOut = 180): void
+    public function waitForPageUpdate(int $timeOut = 180): void
     {
-        $I = $this->getModule('WebDriver');
+        $this->webDriverModule = $this->getModule('WebDriver');
 
         try {
-            $I->waitForJS('return $.active == 0;', $timeOut);
+            $this->webDriverModule->waitForJS('return $.active == 0;', $timeOut);
+
+            $this->webDriverModule->debug('JS check passed: no active requests.');
         } catch (\Facebook\WebDriver\Exception\JavascriptErrorException $exception) {
-            $I->wait($this->defaultDelay);
+            $this->webDriverModule->wait($this->defaultDelay);
+
+            $this->webDriverModule->debug('JS Error: ' . $exception->getMessage());
         }
     }
+
+    public function waitPageLoad($timeout = 10)
+    {
+        $this->webDriverModule->waitForJs('return document.readyState == "complete"', $timeout);
+        $this->waitAjaxLoad($timeout);
+    }
+
+    public function waitAjaxLoad($timeout = 10)
+    {
+        $this->webDriverModule->waitForJS('return !!window.jQuery && window.jQuery.active == 0;', $timeout);
+        $this->webDriverModule->wait($this->defaultDelay);
+    }
 }

tests/_support/Page/IndexPage.php

@@ -239,9 +239,9 @@ public function setAdvancedFilter(TestableInput $filter, string $value): void
         $this->gridView->setAdvancedFilter($filter, $value);
     }
 
-    public function getRowNumberInColumnByValue(string $columnName, string $vaule): int
+    public function getRowNumberInColumnByValue(string $columnName, string $value): int
     {
-        return $this->gridView->getRowNumberInColumnByValue($columnName, $vaule);
+        return $this->gridView->getRowNumberInColumnByValue($columnName, $value);
     }
 
     public function getColumnNumber(string $columnName): int