Fix uptoshape crash when selecting a face without assigned shape

FlachyJoe · chennes · commit ef2156d0f6d1 · 2024-10-17T20:26:14.000-05:00
diff --git a/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp b/src/Mod/PartDesign/Gui/TaskExtrudeParameters.cpp
@@ -397,8 +397,10 @@ void TaskExtrudeParameters::selectedShapeFace(const Gui::SelectionChanges& msg)
     }
 
     auto base = static_cast<Part::Feature*>(extrude->UpToShape.getValue());
-
-    if (strcmp(msg.pObjectName, base->getNameInDocument()) != 0) {
+    if (!base){
+        base = static_cast<Part::Feature*>(extrude);
+    }
+    else if (strcmp(msg.pObjectName, base->getNameInDocument()) != 0) {
         return;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -397,8 +397,10 @@ void TaskExtrudeParameters::selectedShapeFace(const Gui::SelectionChanges& msg)`
`397`	`397`	`}`
`398`	`398`
`399`	`399`	`auto base = static_cast<Part::Feature*>(extrude->UpToShape.getValue());`
`400`		`-`
`401`		`- if (strcmp(msg.pObjectName, base->getNameInDocument()) != 0) {`
	`400`	`+ if (!base){`
	`401`	`+ base = static_cast<Part::Feature*>(extrude);`
	`402`	`+ }`
	`403`	`+ else if (strcmp(msg.pObjectName, base->getNameInDocument()) != 0) {`
`402`	`404`	`return;`
`403`	`405`	`}`
`404`	`406`