Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hooks API to @benzene/ws #57

Open
hoangvvo opened this issue May 27, 2021 · 0 comments
Open

Add hooks API to @benzene/ws #57

hoangvvo opened this issue May 27, 2021 · 0 comments
Labels
Milestone

Comments

@hoangvvo
Copy link
Owner

hoangvvo commented May 27, 2021

We needed to add hooks API like onStart and onComplete to @benzene/ws. We use to have it (#10) but they were removed in a later release due to certain memory leak concerns.

This issue is another visit to this matter. We need to know:

  • which hooks are needed
  • implementation/api, which variables can be accessed, mutated during those lifecycles.

For inspirations, we can look at https://github.com/apollographql/subscriptions-transport-ws and https://github.com/enisdenjo/graphql-ws.

@hoangvvo hoangvvo added this to the 1.0 milestone May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant