Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename MD5_HASH to MD5_HEX #1

Open
open-gdsn opened this issue May 10, 2019 · 1 comment
Open

Rename MD5_HASH to MD5_HEX #1

open-gdsn opened this issue May 10, 2019 · 1 comment

Comments

@open-gdsn
Copy link

Since that is what it actually is... ;-)

https://github.com/holodeck-b2b/bdxr-common/blob/821cd50d99b2f144bcb31b23b59b4c12e25a7b52/generic-client/src/test/java/org/holodeckb2b/bdxr/sml/PEPPOLHostNameGeneratorTest.java#L34
@holodeck-b2b holodeck-b2b transferred this issue from holodeck-b2b/bdxr-common Apr 15, 2021
@holodeck-b2b
Copy link
Owner

It actually is the Hex representation of the hash, so the most complete name here would even be MD5_HASH_HEX :-)
But as its just in a test class and the meaning still clear this change is also low prio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@holodeck-b2b @open-gdsn