Optimize sensor list performance #4853
Merged
+10
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Prevent the list being filtered again every time something in the database is changed but the values don't change - Perform filtering of the sensors list on the IO thread instead of the main thread
jpelgrom
force-pushed
the
optimize-sensors-list
branch
from
f78a926
to
3c7ddc9
Compare
dshokouhi
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4808. A trace showed me a lot of time spent on filtering the list which shouldn't happen when toggling the sensor setting:
Screenshots
n/a but it is noticeable when using the list
Link to pull request in Documentation repository
n/a
Any other notes