Multiple integrations have copied a design mistake I made for Bluetooth devices #137114

bdraco · 2025-02-01T18:32:51Z

The problem

Every few days we get an issue report about a device a user ignored and forgot about, and than can no longer get set up. Sometimes its a govee device, sometimes its a switchbot device, but the pattern is consistent.

Allow ignored devices to be selected in the user step and replace the ignored entry.

Note that some non-bluetooth devices have the same issue

homeassistant/components/wiz/config_flow.py: current_unique_ids = self._async_current_ids()
homeassistant/components/steamist/config_flow.py: current_unique_ids = self._async_current_ids()
Allow ignored screenlogic devices to be set up from the user flow #137315 homeassistant/components/screenlogic/config_flow.py: existing = self._async_current_ids()
homeassistant/components/onkyo/config_flow.py: current_unique_ids = self._async_current_ids()
Allow ignored IronOS devices to be set up from the user flow #138223 homeassistant/components/iron_os/config_flow.py: current_addresses = self._async_current_ids()
homeassistant/components/energenie_power_sockets/config_flow.py: currently_configured = self._async_current_ids(include_ignore=True)
homeassistant/components/elkm1/config_flow.py: current_unique_ids = self._async_current_ids()
homeassistant/components/asuswrt/config_flow.py: for unique_id in self._async_current_ids()

What version of Home Assistant Core has the issue?

dev

What was the last working version of Home Assistant Core?

dev

What type of installation are you running?

Home Assistant OS

Integration causing the issue

No response

Link to integration documentation on our website

No response

Diagnostics information

No response

Example YAML snippet

Anything in the logs that might be useful for us?

Additional information

No response

home-assistant · 2025-02-01T18:57:05Z

Hey there @vincegio, @LaStrada, mind taking a look at this issue as it has been labeled with an integration (airthings_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airthings_ble can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign airthings_ble Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

airthings_ble documentation
airthings_ble source
_{^{(message by IssueLinks)}}

home-assistant · 2025-02-01T18:57:10Z

Hey there @aschmitz, @thecode, @Anrijs, mind taking a look at this issue as it has been labeled with an integration (aranet) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of aranet can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign aranet Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

aranet documentation
aranet source
_{^{(message by IssueLinks)}}

home-assistant · 2025-02-01T18:57:20Z

bluemaestro documentation
bluemaestro source

home-assistant · 2025-02-01T18:58:07Z

govee_ble documentation
govee_ble source

home-assistant · 2025-02-01T18:58:07Z

bluetooth documentation
bluetooth source

home-assistant · 2025-02-01T18:58:07Z

Hey there @emontnemery, mind taking a look at this issue as it has been labeled with an integration (improv_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of improv_ble can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign improv_ble Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

improv_ble documentation
improv_ble source
_{^{(message by IssueLinks)}}

home-assistant · 2025-02-01T18:58:07Z

inkbird documentation
inkbird source

home-assistant · 2025-02-01T18:58:07Z

Hey there @bdr99, mind taking a look at this issue as it has been labeled with an integration (eufylife_ble) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of eufylife_ble can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign eufylife_ble Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

eufylife_ble documentation
eufylife_ble source
_{^{(message by IssueLinks)}}

home-assistant · 2025-02-01T18:58:08Z

Hey there @elupus, mind taking a look at this issue as it has been labeled with an integration (gardena_bluetooth) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of gardena_bluetooth can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign gardena_bluetooth Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

gardena_bluetooth documentation
gardena_bluetooth source
_{^{(message by IssueLinks)}}

home-assistant · 2025-02-01T19:00:47Z

Hey there @Lash-L, mind taking a look at this issue as it has been labeled with an integration (oralb) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of oralb can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Renames the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign oralb Removes the current integration label and assignees on the issue, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

oralb documentation
oralb source
_{^{(message by IssueLinks)}}

almost same fix as the others for #137114 except we previously gave them a hint that they had an ignored adapter and aborted, now we simply replace it instead of making them figure out how to unignore it and set it up.

sbidy · 2025-03-19T21:15:16Z

Hey @bdraco could you please help me (again) to create a test for this for the Wiz integration?
https://github.com/home-assistant/core/blob/dev/tests/components/wiz/test_config_flow.py

It seems I have the issue too ->

core/homeassistant/components/wiz/config_flow.py

Line 127 in 100e442

current_unique_ids = self._async_current_ids()

Thank you for your help ... I'm terrible in writing tests especially for hass 😒

thecode · 2025-03-21T10:49:23Z

Hey @bdraco could you please help me (again) to create a test for this for the Wiz integration? https://github.com/home-assistant/core/blob/dev/tests/components/wiz/test_config_flow.py

It seems I have the issue too ->

core/homeassistant/components/wiz/config_flow.py

Line 127 in 100e442

current_unique_ids = self._async_current_ids()
Thank you for your help ... I'm terrible in writing tests especially for hass 😒

Can you make a PR to try to fix it? than we can try to help with a test on the PR, also try to make a test if you can, #137315 can be used as an example.

bdraco self-assigned this Feb 1, 2025

bdraco added the integration: airthings_ble label Feb 1, 2025

bdraco added the integration: aranet label Feb 1, 2025

home-assistant bot assigned thecode Feb 1, 2025

bdraco added the integration: bluemaestro label Feb 1, 2025

home-assistant bot added the by-code-owner label Feb 1, 2025

bdraco added integration: bluetooth integration: govee_ble integration: inkbird integration: bthome integration: eufylife_ble integration: dormakaba_dkey integration: gardena_bluetooth integration: idasen_desk integration: improv_ble labels Feb 1, 2025

home-assistant bot assigned Ernst79, elupus, emontnemery and abmantis and unassigned elupus and emontnemery Feb 1, 2025

thecode mentioned this issue Feb 1, 2025

Allow ignored Aranet devices to be set up from the user flow #137121

Merged

19 tasks

apt-itude mentioned this issue Feb 1, 2025

Allow ignored tilt_ble devices to be set up from user flow #137123

Merged

19 tasks

abmantis mentioned this issue Feb 3, 2025

Allow ignored idasen_desk devices to be set up from the user flow #137253

Merged

19 tasks

dieselrabbit mentioned this issue Feb 4, 2025

Allow ignored screenlogic devices to be set up from the user flow #137315

Merged

19 tasks

bdraco mentioned this issue Feb 4, 2025

Allow ignored Bluetooth adapters to be set up from the user flow #137373

Merged

19 tasks

tr4nt0r mentioned this issue Feb 10, 2025

Allow ignored IronOS devices to be set up from the user flow #138223

Merged

19 tasks

bdraco mentioned this issue Feb 21, 2025

Allow ignored thermobeacon devices to be set up from the user flow #139009

Merged

19 tasks

This was referenced Mar 14, 2025

Allow configuring ignored devices from improve_ble user flow #140595

Merged

Allow configuring ignored devices from dormakaba_dkey user flow #140596

Merged

emontnemery added the no-stale label Mar 14, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple integrations have copied a design mistake I made for Bluetooth devices #137114

Multiple integrations have copied a design mistake I made for Bluetooth devices #137114

bdraco commented Feb 1, 2025 •

edited by emontnemery

Loading

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

sbidy commented Mar 19, 2025 •

edited

Loading

thecode commented Mar 21, 2025

Multiple integrations have copied a design mistake I made for Bluetooth devices #137114

Multiple integrations have copied a design mistake I made for Bluetooth devices #137114

Comments

bdraco commented Feb 1, 2025 • edited by emontnemery Loading

The problem

What version of Home Assistant Core has the issue?

What was the last working version of Home Assistant Core?

What type of installation are you running?

Integration causing the issue

Link to integration documentation on our website

Diagnostics information

Example YAML snippet

Anything in the logs that might be useful for us?

Additional information

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

home-assistant bot commented Feb 1, 2025

sbidy commented Mar 19, 2025 • edited Loading

thecode commented Mar 21, 2025

bdraco commented Feb 1, 2025 •

edited by emontnemery

Loading

sbidy commented Mar 19, 2025 •

edited

Loading