Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typographical glitches in the UI that carry over to translations #22401

Closed
NoRi2909 opened this issue Oct 16, 2024 · 5 comments · Fixed by #22402
Closed

Small typographical glitches in the UI that carry over to translations #22401

NoRi2909 opened this issue Oct 16, 2024 · 5 comments · Fixed by #22402

Comments

@NoRi2909
Copy link
Contributor

NoRi2909 commented Oct 16, 2024

Describe the issue you are experiencing

Two small typographical issues, easy to fix:.

  1. Remove the inconsistent point at the end:

Add dashboard excessive dot

"iframe": {
"title": "Webpage",
"description": "Integrate a webpage as a dashboard."


  1. Change the point into a colon as this is the label for the edit fields below it:

Select devices - colon missing

"device_tracker_intro": "Select the devices that belong to this person.",

What version of Home Assistant Core has the issue?

core-2024.10.2

j4n-e4t added a commit to j4n-e4t/home-assistant-frontend that referenced this issue Oct 16, 2024
@j4n-e4t
Copy link
Contributor

j4n-e4t commented Oct 16, 2024

Hi @NoRi2909,

I've opened a PR for this. I've also spotted another "point" in your second screenshot ("Allow access using..."). Removed that as well. See #22402

@NoRi2909
Copy link
Contributor Author

@j4n-e4t Very nice. That other point should be OK as this concludes a sentence.

In German just the use of periods (yes, those words … :-)) in headlines is not OK.

@j4n-e4t
Copy link
Contributor

j4n-e4t commented Oct 16, 2024

I've now added it back ;-)
Should be good to go now

@NoRi2909
Copy link
Contributor Author

@j4n-e4t If you like to submit one more PR, I just updated this one here with the links to the source files, making it easier to proceed:

#22324

It's also just text changes so it should be no big deal to get this approved.

@j4n-e4t
Copy link
Contributor

j4n-e4t commented Oct 16, 2024

Thank you for the update. I think I'll do that tomorrow. It's late right now. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants