Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle S2 inclusion via Inclusion Controller #45

Open
AlCalzone opened this issue Sep 5, 2024 · 3 comments · May be fixed by home-assistant/frontend#23100
Open

Handle S2 inclusion via Inclusion Controller #45

AlCalzone opened this issue Sep 5, 2024 · 3 comments · May be fixed by home-assistant/frontend#23100
Assignees
@MindFreeze
Labels
backend This bug or request (primary) involves the Home Assistant backend/integration (and its dependencies) frontend This bug or request (primary) involves the Home Assistant frontend zwave-certification Required for Z-Wave certification

Comments

@AlCalzone
Copy link
Member

zwave-js/node-zwave-js#5888 for background

The ideal course of action to solve this is outlined here.

HA must then prompt the user to enter PIN and/or grant security classes when asked.

update [july 4th 2024]
Just add a listener in the zwave_js frontend panel to popup a dialog when this happens.
@AlCalzone AlCalzone converted this from a draft issue Sep 5, 2024
@AlCalzone AlCalzone added the zwave-certification Required for Z-Wave certification label Sep 5, 2024
@MindFreeze
Copy link
Collaborator

So an event must be sent from the driver all the way to the HA frontend.
How far along is this? Is it supported in zwavejs, server, HA lib, HA core? I know it's not in the frontend

@AlCalzone
Copy link
Member Author

The callback/event itself is already looped through, as it's the same that's used during the normal S2 inclusion flow to show the PIN entry etc.

The core addon may need to tell the server to set the callbacks on start if it doesn't already:
https://github.com/zwave-js/zwave-js-server/blob/1fb161d20a6714489f8e05ad59e7cb66f18ba5cd/src/lib/server.ts#L503

When using Z-Wave JS UI, this should already be handled correctly. Z-UI receives the events only when it is open, otherwise they are forwarded to HA.

@MindFreeze
Copy link
Collaborator

Looks like the event is always enabled when starting the server from the CLI so the addon must be fine https://github.com/zwave-js/zwave-js-server/blob/1fb161d20a6714489f8e05ad59e7cb66f18ba5cd/src/bin/server.ts#L186

@MindFreeze MindFreeze added frontend This bug or request (primary) involves the Home Assistant frontend backend This bug or request (primary) involves the Home Assistant backend/integration (and its dependencies) labels Dec 2, 2024
This was referenced Dec 2, 2024
Open
Open
@MindFreeze MindFreeze self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MindFreeze MindFreeze

Labels
backend This bug or request (primary) involves the Home Assistant backend/integration (and its dependencies) frontend This bug or request (primary) involves the Home Assistant frontend zwave-certification Required for Z-Wave certification
Projects
Z-Wave JS: Road to Certification
Status: Later
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ZwaveJS: Handle S2 inclusion via Inclusion Controller home-assistant/frontend
2 participants
@MindFreeze @AlCalzone