Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The checks for the conventional commits have some flaws #16

Open
ilyasmez opened this issue Mar 13, 2020 · 0 comments
Open

The checks for the conventional commits have some flaws #16

ilyasmez opened this issue Mar 13, 2020 · 0 comments

Comments

@ilyasmez
Copy link

For some context: #15

The current implementation to check against the Conventional Commits specs is a little bit loose.
Right now it considers the following commit messages "feature 1", "feather weight", "defeat your fear", "not-a-feature really" as minor change, and "f!rstword", "Hi! How are you?" as a major.

Let's use some robust checks. Regex can be a good solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant