-
-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: compare bundle size #3661
ci: compare bundle size #3661
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3661 +/- ##
=======================================
Coverage 91.69% 91.70%
=======================================
Files 159 159
Lines 10138 10145 +7
Branches 2976 2908 -68
=======================================
+ Hits 9296 9303 +7
Misses 840 840
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Hi @m-shaka, could you please check this? |
This reverts commit 7861d1a.
Hi @k2tzumi! Can you review this, you too? |
perf-measures-bundle-check-on-pr: | ||
name: 'Bundle Check on PR' | ||
runs-on: ubuntu-latest | ||
if: github.event_name == 'pull_request' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: Does the bundle size change every time?
Or does it change only when a specific file is changed?
Should I integrate workflow jobs when importing into #3491? Should we keep them separate? I am pondering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
q: Does the bundle size change every time?
Or does it change only when a specific file is changed?
it change only when a specific file is changed
is right.
Only when a core file is changed.
Should I integrate workflow jobs when importing into #3491? Should we keep them separate? I am pondering.
I have limited knowledge about it, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want to run a job only when a core file is changed, can I identify the core file?
Also, will the number of target core file types increase or decrease frequently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there will be little or no increase or decrease in the core file.
So it is a good idea to measure when it should be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to keep this as a TODO/NOTE as it seems a bit difficult to implement.
hi @yusukebe, this pr should be ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being late. Great work!
It would be nicer if you could see a unit(like KB or MB) of bundle size, but it's OK to add it later
Agreed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you all! Let's go with this. |
The author should do the following, if applicable
bun run format:fix && bun run lint:fix
to format the code