Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: compare bundle size #3661

Merged
merged 7 commits into from
Nov 15, 2024
Merged

ci: compare bundle size #3661

merged 7 commits into from
Nov 15, 2024

Conversation

EdamAme-x
Copy link
Contributor

@EdamAme-x EdamAme-x commented Nov 12, 2024

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

@EdamAme-x
Copy link
Contributor Author

if this pr is merged, before.js will also be output to show the change in bundle size.

image

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.70%. Comparing base (7e17b76) to head (3aef3ae).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3661   +/-   ##
=======================================
  Coverage   91.69%   91.70%           
=======================================
  Files         159      159           
  Lines       10138    10145    +7     
  Branches     2976     2908   -68     
=======================================
+ Hits         9296     9303    +7     
  Misses        840      840           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EdamAme-x
Copy link
Contributor Author

Hi @m-shaka, could you please check this?

@yusukebe
Copy link
Member

Hi @k2tzumi! Can you review this, you too?

Comment on lines +229 to +232
perf-measures-bundle-check-on-pr:
name: 'Bundle Check on PR'
runs-on: ubuntu-latest
if: github.event_name == 'pull_request'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does the bundle size change every time?
Or does it change only when a specific file is changed?

Should I integrate workflow jobs when importing into #3491? Should we keep them separate? I am pondering.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q: Does the bundle size change every time?
Or does it change only when a specific file is changed?

it change only when a specific file is changed is right.

Only when a core file is changed.

Should I integrate workflow jobs when importing into #3491? Should we keep them separate? I am pondering.

I have limited knowledge about it, sorry.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to run a job only when a core file is changed, can I identify the core file?
Also, will the number of target core file types increase or decrease frequently?

Copy link
Contributor Author

@EdamAme-x EdamAme-x Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there will be little or no increase or decrease in the core file.
So it is a good idea to measure when it should be changed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to keep this as a TODO/NOTE as it seems a bit difficult to implement.

https://stackoverflow.com/questions/70708306/github-actions-run-step-job-in-a-workflow-if-changes-happen-in-specific-folde

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Nov 14, 2024

what happen, DDoS...?
image

@EdamAme-x
Copy link
Contributor Author

hi @yusukebe, this pr should be ready.

Copy link
Contributor

@k2tzumi k2tzumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@m-shaka m-shaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being late. Great work!

It would be nicer if you could see a unit(like KB or MB) of bundle size, but it's OK to add it later

@EdamAme-x
Copy link
Contributor Author

EdamAme-x commented Nov 15, 2024

It would be nicer if you could see a unit(like KB or MB) of bundle size, but it's OK to add it later

Agreed!
We will add custom metrics later, so it seems like a good idea to add them at that time.

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@EdamAme-x @k2tzumi @m-shaka

Thank you all! Let's go with this.

@yusukebe yusukebe merged commit 53bd319 into honojs:main Nov 15, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants